Clarify ownership of GpuVideoDecodeAcceleratorHost and avoid crash on context loss.

Clarify ownership of GpuVideoDecodeAcceleratorHost and avoid crash on context loss.

GpuVideoDecoder owns GpuVideoDecodeAcceleratorHost; it was a bug that
~CommandBufferProxyImpl() called GpuVideoDecodeAcceleratorHost::Destroy() (since
the latter deletes |this|).

This bug was uncovered due to an unrelated GPU-process crashing bug, which
triggered context loss and the subsequent stack in the linked bug.  With this
change, killing the GPU process mid-playback fires a JS error on the <video> tag
(correctly), but the renderer keeps on just fine.

BUG=140138
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149985

[Ami GONE FROM CHROMIUM, 2012-08-03 20:46:15]

piman: please review
posciak: FYI

[piman, 2012-08-03 21:09:02]

lgtm

https://chromiumcodereview.appspot.com/10852009/diff/2001/media/filters/gpu_v...
File media/filters/gpu_video_decoder.cc (right):

https://chromiumcodereview.appspot.com/10852009/diff/2001/media/filters/gpu_v...
media/filters/gpu_video_decoder.cc:167: // called, not just posted.  We can't
simply PostTaskAndReply using |closure|
nit: the comment about |closure| isn't meaningful anymore.

[Ami GONE FROM CHROMIUM, 2012-08-03 21:53:15]

Thanks for the quick review.

https://chromiumcodereview.appspot.com/10852009/diff/2001/media/filters/gpu_v...
File media/filters/gpu_video_decoder.cc (right):

https://chromiumcodereview.appspot.com/10852009/diff/2001/media/filters/gpu_v...
media/filters/gpu_video_decoder.cc:167: // called, not just posted.  We can't
simply PostTaskAndReply using |closure|
On 2012/08/03 21:09:02, piman wrote:
> nit: the comment about |closure| isn't meaningful anymore.

Done.

[commit-bot: I haz the power, 2012-08-03 21:53:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fischman@chromium.org/10852009/7001

[commit-bot: I haz the power, 2012-08-04 00:31:57]

Change committed as 149985