content/common/gpu/client/gpu_video_decode_accelerator_host.h - Issue 10852009: Clarify ownership of GpuVideoDecodeAcceleratorHost and avoid crash on context loss.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/gpu_video_decode_accelerator_host.h

Issue 10852009: Clarify ownership of GpuVideoDecodeAcceleratorHost and avoid crash on context loss. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/client/command_buffer_proxy_impl.cc ('k') | content/common/gpu/client/gpu_video_decode_accelerator_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/client/gpu_video_decode_accelerator_host.h

diff --git a/content/common/gpu/client/gpu_video_decode_accelerator_host.h b/content/common/gpu/client/gpu_video_decode_accelerator_host.h

index e33129fa45fd712ee1b0a6f6c4338487a717d038..b46310ace1af5226de30cea94fb6945b347b7059 100644

--- a/content/common/gpu/client/gpu_video_decode_accelerator_host.h

+++ b/content/common/gpu/client/gpu_video_decode_accelerator_host.h

@@ -25,7 +25,6 @@ class GpuVideoDecodeAcceleratorHost

GpuVideoDecodeAcceleratorHost(GpuChannelHost* channel,

int32 decoder_route_id,

media::VideoDecodeAccelerator::Client* client);

- virtual ~GpuVideoDecodeAcceleratorHost();

// IPC::Listener implementation.

virtual void OnChannelError() OVERRIDE;

@@ -42,6 +41,9 @@ class GpuVideoDecodeAcceleratorHost

virtual void Destroy() OVERRIDE;

private:

+ // Only Destroy() should be deleting |this|.

+ virtual ~GpuVideoDecodeAcceleratorHost();

void Send(IPC::Message* message);

void OnBitstreamBufferProcessed(int32 bitstream_buffer_id);