Dead code elimination: scythe.chrome_functions:segment.path %media% edition, round 1.

Dead code elimination: scythe.chrome_functions:segment.path %media% edition, round 1.

Internal-only site: http://go/videostack/engineering/dead-code-elimination

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150129

[Ami GONE FROM CHROMIUM, 2012-08-06 01:00:58]

Some highlights from this CL: 
- Kills ENABLE_SUBSAMPLING hoohah, since it's unused.  (libyuv has this now, I
think).
- Certain switches / constants / methods that are expected to hang around for a
long time, are present in multi-platform files, but are only used in some
platform's platform-specific code, got #ifdef'd in now.  This will prevent them
from showing up as recurring noise in future analyses of dead code, as well as
annotate them for all to see as being platform-specific (a good thing, IMO).
- Killed the craxy openmax stubbing for integration into media/ which never went
anywhere.

https://chromiumcodereview.appspot.com/10837118/diff/4003/content/browser/ren...
File content/browser/renderer_host/media/media_stream_requester.h (left):

https://chromiumcodereview.appspot.com/10837118/diff/4003/content/browser/ren...
content/browser/renderer_host/media/media_stream_requester.h:37: virtual void
DevicesEnumerationFailed(const std::string& label) = 0;
wjia: is the fact that this method and the next are dead code a signal that
we're missing needed error handling?

https://chromiumcodereview.appspot.com/10837118/diff/4003/content/common/gpu/...
File content/common/gpu/media/h264_parser.h (right):

https://chromiumcodereview.appspot.com/10837118/diff/4003/content/common/gpu/...
content/common/gpu/media/h264_parser.h:174: int colour_plane_id;  //
TODO(posciak): use this!  http://crbug.com/139878
Just annotating to ease future analysis runs.

[scherkus (not reviewing), 2012-08-06 18:00:59]

this is LGTM but I do wonder about the removal of error reporting (i.e., should
we be reporting errors? are errors reported on mac/win but not linux?)

[commit-bot: I haz the power, 2012-08-06 18:08:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fischman@chromium.org/10837118/4003

[Ami GONE FROM CHROMIUM, 2012-08-06 18:09:44]

On 2012/08/06 18:00:59, scherkus wrote:
> this is LGTM but I do wonder about the removal of error reporting (i.e.,
should
> we be reporting errors? are errors reported on mac/win but not linux?)

If we're reporting errors, I'm not seeing it.
I'll let Wei weigh in with the answer to the "should we be reporting errors"
question.  

CQ'ing for now.

[commit-bot: I haz the power, 2012-08-06 18:11:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fischman@chromium.org/10837118/4003

[commit-bot: I haz the power, 2012-08-06 19:32:02]

Change committed as 150129