Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 10837111: [Sync] Print out notification state explicitly in about:sync (Closed)

Created:
8 years, 4 months ago by akalin
Modified:
8 years, 4 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

[Sync] Print out notification state explicitly in about:sync BUG=139430 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150251

Patch Set 1 #

Patch Set 2 : Fix compile error #

Patch Set 3 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -50 lines) Patch
M chrome/browser/resources/sync_internals/notifications.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/sync_internals/notifications.js View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M sync/internal_api/sync_manager_impl.h View 1 3 chunks +9 lines, -0 lines 0 comments Download
M sync/internal_api/sync_manager_impl.cc View 1 5 chunks +41 lines, -31 lines 0 comments Download
M sync/internal_api/sync_manager_impl_unittest.cc View 1 2 2 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
akalin
+zea for review
8 years, 4 months ago (2012-08-03 23:56:03 UTC) #1
akalin
On 2012/08/03 23:56:03, akalin wrote: > +zea for review ping!
8 years, 4 months ago (2012-08-06 18:03:04 UTC) #2
Nicolas Zea
lgtm
8 years, 4 months ago (2012-08-06 18:35:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/10837111/4003
8 years, 4 months ago (2012-08-06 19:24:40 UTC) #4
commit-bot: I haz the power
Try job failure for 10837111-4003 (retry) on linux_rel for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-06 19:56:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/10837111/4003
8 years, 4 months ago (2012-08-07 00:45:03 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-07 03:48:48 UTC) #7
Change committed as 150251

Powered by Google App Engine
This is Rietveld 408576698