Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Unified Diff: sync/internal_api/sync_manager_impl_unittest.cc

Issue 10837111: [Sync] Print out notification state explicitly in about:sync (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix tests Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/internal_api/sync_manager_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/internal_api/sync_manager_impl_unittest.cc
diff --git a/sync/internal_api/sync_manager_impl_unittest.cc b/sync/internal_api/sync_manager_impl_unittest.cc
index 0e6b4643f35dd4d81dbe5145385b93b832138a2e..bd2ffeff0ad07d9f90775a906c44fdbf12e7fc7d 100644
--- a/sync/internal_api/sync_manager_impl_unittest.cc
+++ b/sync/internal_api/sync_manager_impl_unittest.cc
@@ -973,12 +973,13 @@ TEST_F(SyncManagerTest, ProcessJsMessage) {
StrictMock<MockJsReplyHandler> reply_handler;
- ListValue false_args;
- false_args.Append(Value::CreateBooleanValue(false));
+ ListValue disabled_args;
+ disabled_args.Append(
+ Value::CreateStringValue("TRANSIENT_NOTIFICATION_ERROR"));
EXPECT_CALL(reply_handler,
HandleJsReply("getNotificationState",
- HasArgsAsList(false_args)));
+ HasArgsAsList(disabled_args)));
// This message should be dropped.
SendJsMessage("unknownMessage", kNoArgs, reply_handler.AsWeakHandle());
@@ -1261,17 +1262,17 @@ TEST_F(SyncManagerTest, OnNotificationStateChange) {
InSequence dummy;
StrictMock<MockJsEventHandler> event_handler;
- DictionaryValue true_details;
- true_details.SetBoolean("enabled", true);
- DictionaryValue false_details;
- false_details.SetBoolean("enabled", false);
+ DictionaryValue enabled_details;
+ enabled_details.SetString("state", "NO_NOTIFICATION_ERROR");
+ DictionaryValue disabled_details;
+ disabled_details.SetString("state", "TRANSIENT_NOTIFICATION_ERROR");
EXPECT_CALL(event_handler,
HandleJsEvent("onNotificationStateChange",
- HasDetailsAsDictionary(true_details)));
+ HasDetailsAsDictionary(enabled_details)));
EXPECT_CALL(event_handler,
HandleJsEvent("onNotificationStateChange",
- HasDetailsAsDictionary(false_details)));
+ HasDetailsAsDictionary(disabled_details)));
SimulateEnableNotificationsForTest();
SimulateDisableNotificationsForTest(TRANSIENT_NOTIFICATION_ERROR);
« no previous file with comments | « sync/internal_api/sync_manager_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698