[Sync] Print out notification state explicitly in about:sync

sync/internal_api/sync_manager_impl_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Unit tests for the SyncApi. Note that a lot of the underlying
 // functionality is provided by the Syncable layer, which has its own
 // unit tests. We'll test SyncApi specific things in this harness.
 
 #include <cstddef>
 #include <map>
@@ skipping 955 matching lines @@
 TEST_F(SyncManagerTest, UpdateRegisteredInvalidationIds) {
   EXPECT_CALL(*sync_notifier_mock_, UpdateRegisteredIds(NULL, ObjectIdSet()));
   sync_manager_.UpdateRegisteredInvalidationIds(NULL, ObjectIdSet());
 }
 
 TEST_F(SyncManagerTest, ProcessJsMessage) {
   const JsArgList kNoArgs;
 
   StrictMock<MockJsReplyHandler> reply_handler;
 
-  ListValue false_args;
-  false_args.Append(Value::CreateBooleanValue(false));
+  ListValue disabled_args;
+  disabled_args.Append(
+      Value::CreateStringValue("TRANSIENT_NOTIFICATION_ERROR"));
 
   EXPECT_CALL(reply_handler,
               HandleJsReply("getNotificationState",
-                            HasArgsAsList(false_args)));
+                            HasArgsAsList(disabled_args)));
 
   // This message should be dropped.
   SendJsMessage("unknownMessage", kNoArgs, reply_handler.AsWeakHandle());
 
   SendJsMessage("getNotificationState", kNoArgs, reply_handler.AsWeakHandle());
 }
 
 TEST_F(SyncManagerTest, ProcessJsMessageGetRootNodeDetails) {
   const JsArgList kNoArgs;
 
@@ skipping 262 matching lines @@
   ASSERT_EQ(directory_size, node_list->GetSize());
   ASSERT_TRUE(node_list->GetDictionary(0, &first_result));
   EXPECT_TRUE(first_result->HasKey("ID"));
   EXPECT_TRUE(first_result->HasKey("NON_UNIQUE_NAME"));
 }
 
 TEST_F(SyncManagerTest, OnNotificationStateChange) {
   InSequence dummy;
   StrictMock<MockJsEventHandler> event_handler;
 
-  DictionaryValue true_details;
-  true_details.SetBoolean("enabled", true);
-  DictionaryValue false_details;
-  false_details.SetBoolean("enabled", false);
+  DictionaryValue enabled_details;
+  enabled_details.SetString("state", "NO_NOTIFICATION_ERROR");
+  DictionaryValue disabled_details;
+  disabled_details.SetString("state", "TRANSIENT_NOTIFICATION_ERROR");
 
   EXPECT_CALL(event_handler,
               HandleJsEvent("onNotificationStateChange",
-                            HasDetailsAsDictionary(true_details)));
+                            HasDetailsAsDictionary(enabled_details)));
   EXPECT_CALL(event_handler,
               HandleJsEvent("onNotificationStateChange",
-                            HasDetailsAsDictionary(false_details)));
+                            HasDetailsAsDictionary(disabled_details)));
 
   SimulateEnableNotificationsForTest();
   SimulateDisableNotificationsForTest(TRANSIENT_NOTIFICATION_ERROR);
 
   SetJsEventHandler(event_handler.AsWeakHandle());
   SimulateEnableNotificationsForTest();
   SimulateDisableNotificationsForTest(TRANSIENT_NOTIFICATION_ERROR);
   SetJsEventHandler(WeakHandle<JsEventHandler>());
 
   SimulateEnableNotificationsForTest();
@@ skipping 1497 matching lines @@
 
   // Verify only the non-disabled types remain after cleanup.
   sync_manager_.PurgeDisabledTypes(enabled_types, new_enabled_types);
   EXPECT_TRUE(new_enabled_types.Equals(
       Union(sync_manager_.InitialSyncEndedTypes(), partial_enabled_types)));
   EXPECT_TRUE(disabled_types.Equals(
       sync_manager_.GetTypesWithEmptyProgressMarkerToken(ModelTypeSet::All())));
 }
 
 }  // namespace