Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(949)

Issue 10836317: Revert 152017 - Add chrome.runtime.onStartup, which is fired on browser start. (Closed)

Created:
8 years, 4 months ago by Matt Perry
Modified:
8 years, 4 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Revert 152017 - Add chrome.runtime.onStartup, which is fired on browser start. I reused LazyBackgroundTaskQueue so that this works for regular background pages, which may not be fully loaded by the time this event is dispatched. BUG=132328 Review URL: https://chromiumcodereview.appspot.com/10828218 Reason for revert: introduced a frequent crash TBR=mpcomplete@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152127

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -132 lines) Patch
M chrome/browser/extensions/api/runtime/runtime_api.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/runtime/runtime_api.cc View 1 chunk +1 line, -43 lines 0 comments Download
M chrome/browser/extensions/event_router.cc View 5 chunks +4 lines, -13 lines 0 comments Download
M chrome/browser/extensions/extension_process_manager.cc View 4 chunks +10 lines, -16 lines 0 comments Download
M chrome/browser/extensions/lazy_background_task_queue.cc View 4 chunks +12 lines, -13 lines 0 comments Download
M chrome/common/extensions/api/runtime.json View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/apps/runtime.html View 2 chunks +0 lines, -18 lines 0 comments Download
M chrome/common/extensions/docs/extensions/runtime.html View 2 chunks +0 lines, -18 lines 0 comments Download
M chrome/common/extensions/docs/samples.json View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Matt Perry
8 years, 4 months ago (2012-08-17 19:02:38 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698