Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5773)

Unified Diff: chrome/browser/extensions/extension_process_manager.cc

Issue 10836317: Revert 152017 - Add chrome.runtime.onStartup, which is fired on browser start. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/event_router.cc ('k') | chrome/browser/extensions/lazy_background_task_queue.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_process_manager.cc
===================================================================
--- chrome/browser/extensions/extension_process_manager.cc (revision 152126)
+++ chrome/browser/extensions/extension_process_manager.cc (working copy)
@@ -10,7 +10,6 @@
#include "base/metrics/histogram.h"
#include "base/string_number_conversions.h"
#include "base/time.h"
-#include "chrome/browser/extensions/api/runtime/runtime_api.h"
#include "chrome/browser/extensions/extension_process_manager.h"
#include "chrome/browser/extensions/extension_host.h"
#include "chrome/browser/extensions/extension_info_map.h"
@@ -90,20 +89,16 @@
static void CreateBackgroundHostForExtensionLoad(
ExtensionProcessManager* manager, const Extension* extension) {
- if (extension->has_persistent_background_page())
+ if (extension->has_persistent_background_page()) {
manager->CreateBackgroundHost(extension, extension->GetBackgroundURL());
+ }
}
static void CreateBackgroundHostsForProfileStartup(
- Profile* profile,
- ExtensionProcessManager* manager,
- const ExtensionSet* extensions) {
+ ExtensionProcessManager* manager, const ExtensionSet* extensions) {
for (ExtensionSet::const_iterator extension = extensions->begin();
extension != extensions->end(); ++extension) {
CreateBackgroundHostForExtensionLoad(manager, *extension);
-
- extensions::RuntimeEventRouter::DispatchOnStartupEvent(
- profile, (*extension)->id());
}
}
@@ -562,19 +557,19 @@
const content::NotificationDetails& details) {
switch (type) {
case chrome::NOTIFICATION_EXTENSIONS_READY: {
- Profile* profile = content::Source<Profile>(source).ptr();
- CreateBackgroundHostsForProfileStartup(profile, this,
- profile->GetExtensionService()->extensions());
+ CreateBackgroundHostsForProfileStartup(this,
+ content::Source<Profile>(source).ptr()->
+ GetExtensionService()->extensions());
break;
}
case chrome::NOTIFICATION_EXTENSION_LOADED: {
- Profile* profile = content::Source<Profile>(source).ptr();
- ExtensionService* service = profile->GetExtensionService();
+ ExtensionService* service =
+ content::Source<Profile>(source).ptr()->GetExtensionService();
if (service->is_ready()) {
const Extension* extension =
content::Details<const Extension>(details).ptr();
- CreateBackgroundHostForExtensionLoad(this, extension);
+ ::CreateBackgroundHostForExtensionLoad(this, extension);
}
break;
}
@@ -810,8 +805,7 @@
// service will be NULL.
ExtensionService* service = GetProfile()->GetExtensionService();
if (service && service->is_ready())
- CreateBackgroundHostsForProfileStartup(GetProfile(),
- this, service->extensions());
+ CreateBackgroundHostsForProfileStartup(this, service->extensions());
}
break;
}
« no previous file with comments | « chrome/browser/extensions/event_router.cc ('k') | chrome/browser/extensions/lazy_background_task_queue.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698