Add chrome.runtime.onStartup, which is fired on browser start.

Add chrome.runtime.onStartup, which is fired on browser start.

I reused LazyBackgroundTaskQueue so that this works for regular background
pages, which may not be fully loaded by the time this event is dispatched.

BUG=132328
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152017

[Matt Perry, 2012-08-08 23:48:54]

aa: FYI
yoz: please review

I think I'll have to rename LazyBackgroundTaskQueue now that I'm using it for
persistent background pages too, but I wanted to make sure you're OK with this
approach before doing so.

[Yoyo Zhou, 2012-08-09 00:49:17]

LGTM. Seems fine to me to treat non-lazy background pages as lazy background
pages that happen to start right away.

http://codereview.chromium.org/10828218/diff/1/chrome/browser/extensions/api/...
File chrome/browser/extensions/api/runtime/runtime_api.cc (right):

http://codereview.chromium.org/10828218/diff/1/chrome/browser/extensions/api/...
chrome/browser/extensions/api/runtime/runtime_api.cc:69: if
(!g_browser_process->profile_manager()->IsValidProfile(profile))
What is this for?

http://codereview.chromium.org/10828218/diff/1/chrome/browser/extensions/exte...
File chrome/browser/extensions/extension_process_manager.cc (right):

http://codereview.chromium.org/10828218/diff/1/chrome/browser/extensions/exte...
chrome/browser/extensions/extension_process_manager.cc:106: profile,
(*extension)->id());
Can you use manager->GetProfile() and not have to pass in the Profile*? All the
places where this gets called only observe the original_profile source, which
should match this.

http://codereview.chromium.org/10828218/diff/1/chrome/common/extensions/api/r...
File chrome/common/extensions/api/runtime.json (right):

http://codereview.chromium.org/10828218/diff/1/chrome/common/extensions/api/r...
chrome/common/extensions/api/runtime.json:115: "description": "Fired when the
browser first starts up."
...and profiles are started for the first time?

[Matt Perry, 2012-08-15 20:35:45]

http://codereview.chromium.org/10828218/diff/1/chrome/browser/extensions/api/...
File chrome/browser/extensions/api/runtime/runtime_api.cc (right):

http://codereview.chromium.org/10828218/diff/1/chrome/browser/extensions/api/...
chrome/browser/extensions/api/runtime/runtime_api.cc:69: if
(!g_browser_process->profile_manager()->IsValidProfile(profile))
On 2012/08/09 00:49:17, Yoyo Zhou wrote:
> What is this for?

This method is called via a PostTask, so the profile might not be valid. Though
now I'm thinking that I should probably move this check to the call site.

http://codereview.chromium.org/10828218/diff/1/chrome/browser/extensions/exte...
File chrome/browser/extensions/extension_process_manager.cc (right):

http://codereview.chromium.org/10828218/diff/1/chrome/browser/extensions/exte...
chrome/browser/extensions/extension_process_manager.cc:106: profile,
(*extension)->id());
On 2012/08/09 00:49:17, Yoyo Zhou wrote:
> Can you use manager->GetProfile() and not have to pass in the Profile*? All
the
> places where this gets called only observe the original_profile source, which
> should match this.

GetProfile is private, and I didn't like the other options (making it public, or
adding this method as a friend or static member).

http://codereview.chromium.org/10828218/diff/1/chrome/common/extensions/api/r...
File chrome/common/extensions/api/runtime.json (right):

http://codereview.chromium.org/10828218/diff/1/chrome/common/extensions/api/r...
chrome/common/extensions/api/runtime.json:115: "description": "Fired when the
browser first starts up."
On 2012/08/09 00:49:17, Yoyo Zhou wrote:
> ...and profiles are started for the first time?

True. I wasn't sure how to word that in a way that would make sense to someone
who doesn't work on Chrome.

[Yoyo Zhou, 2012-08-15 20:39:55]

http://codereview.chromium.org/10828218/diff/1/chrome/browser/extensions/exte...
File chrome/browser/extensions/extension_process_manager.cc (right):

http://codereview.chromium.org/10828218/diff/1/chrome/browser/extensions/exte...
chrome/browser/extensions/extension_process_manager.cc:106: profile,
(*extension)->id());
On 2012/08/15 20:35:45, Matt Perry wrote:
> On 2012/08/09 00:49:17, Yoyo Zhou wrote:
> > Can you use manager->GetProfile() and not have to pass in the Profile*? All
> the
> > places where this gets called only observe the original_profile source,
which
> > should match this.
> 
> GetProfile is private, and I didn't like the other options (making it public,
or
> adding this method as a friend or static member).

Weird, for some reason I thought GetProfile would be a simple accessor. I don't
understand why it is the way it is in EPM.

[commit-bot: I haz the power, 2012-08-16 00:03:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/10828218/10

[commit-bot: I haz the power, 2012-08-16 00:59:16]

Try job failure for 10828218-10 (retry) on linux_chromeos for step
"browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2012-08-16 01:25:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/10828218/12

[commit-bot: I haz the power, 2012-08-16 04:54:39]

Try job failure for 10828218-12 (retry) on linux_chromeos for step
"browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2012-08-16 21:26:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/10828218/4014

[Matt Perry, 2012-08-16 22:06:44]

FYI

https://chromiumcodereview.appspot.com/10828218/diff/9005/chrome/browser/exte...
File chrome/browser/extensions/api/runtime/runtime_api.cc (right):

https://chromiumcodereview.appspot.com/10828218/diff/9005/chrome/browser/exte...
chrome/browser/extensions/api/runtime/runtime_api.cc:45: if (extension &&
extension->has_persistent_background_page() && first_call &&
I had to add a check for has_persistent_background_page here because it was
incorrectly starting event pages that didn't register for this event.

[commit-bot: I haz the power, 2012-08-16 23:11:08]

Try job failure for 10828218-4014 (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-08-16 23:17:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/10828218/4014

[commit-bot: I haz the power, 2012-08-17 02:14:25]

Change committed as 152017