Issue 10836065: Improve WorkspaceWindowResizer::CompleteDrag() so that the function moves the window to a root windo

Issue 10836065: Improve WorkspaceWindowResizer::CompleteDrag() so that the function moves the window to a root windo (Closed)

Created:
8 years, 4 months ago by Yusuke Sato

Modified:
8 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org, oshima, mazda

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Improve WorkspaceWindowResizer::CompleteDrag() so that the function moves the window to a root window where the cursor is currently on. This CL depends on http://codereview.chromium.org/10834097/ . BUG=136816 TEST=try Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150762

Patch Set 2 : fix coordinates #

Patch Set 4 : add unit tests, rebase #

Total comments: 2

Patch Set 7 : final rebase #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+221 lines, -45 lines)			Patch
M	ash/display/screen_position_controller.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	ash/display/screen_position_controller.cc	View	1 2 3	6 chunks	+15 lines, -12 lines	0 comments	Download
M	ash/extended_desktop_unittest.cc	View	1 2 3	1 chunk	+29 lines, -0 lines	0 comments	Download
M	ash/test/ash_test_base.cc	View	1 2 3	2 chunks	+15 lines, -0 lines	0 comments	Download
M	ash/wm/workspace/workspace_window_resizer.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ash/wm/workspace/workspace_window_resizer.cc	View	1 2 3	4 chunks	+24 lines, -21 lines	0 comments	Download
M	ash/wm/workspace/workspace_window_resizer_unittest.cc	View	1 2 3 4 5 6	7 chunks	+115 lines, -5 lines	0 comments	Download
M	ui/aura/client/screen_position_client.h	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	ui/aura/window.h	View	1 2 3	2 chunks	+6 lines, -1 line	0 comments	Download
M	ui/aura/window.cc	View	1 2 3	1 chunk	+3 lines, -2 lines	0 comments	Download
M	ui/views/widget/desktop_native_widget_helper_aura.cc	View	1 2 3	1 chunk	+3 lines, -1 line	0 comments	Download
M	ui/views/widget/native_widget_aura.cc	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM http://codereview.chromium.org/10836065/diff/7004/ash/wm/workspace/workspace_window_resizer_unittest.cc File ash/wm/workspace/workspace_window_resizer_unittest.cc (right): http://codereview.chromium.org/10836065/diff/7004/ash/wm/workspace/workspace_window_resizer_unittest.cc#newcode501 ash/wm/workspace/workspace_window_resizer_unittest.cc:501: SetGridSize(0); Why do you need SetGridSize so many ...

8 years, 4 months ago (2012-08-09 00:47:38 UTC) #4

Yusuke Sato

http://codereview.chromium.org/10836065/diff/7004/ash/wm/workspace/workspace_window_resizer_unittest.cc File ash/wm/workspace/workspace_window_resizer_unittest.cc (right): http://codereview.chromium.org/10836065/diff/7004/ash/wm/workspace/workspace_window_resizer_unittest.cc#newcode501 ash/wm/workspace/workspace_window_resizer_unittest.cc:501: SetGridSize(0); On 2012/08/09 00:47:38, sky wrote: > Why do ...

8 years, 4 months ago (2012-08-09 00:58:00 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/10836065/38

8 years, 4 months ago (2012-08-09 05:10:15 UTC) #6

commit-bot: I haz the power

Try job failure for 10836065-38 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...

8 years, 4 months ago (2012-08-09 05:45:34 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/10836065/17003

8 years, 4 months ago (2012-08-09 05:53:43 UTC) #8

Change committed as 150762

Expand Messages | Collapse Messages