Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 10834248: Clean-up inline members of nested classes (gpu/) (Closed)

Created:
8 years, 4 months ago by hans
Modified:
8 years, 4 months ago
Reviewers:
greggman
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

Clean-up inline members of nested classes (gpu/) Due to a bug, the Clang-plugin style checker failed to warn about inline constructors, destructors, non-empty virtual methods, etc. for nested classes. The plugin has been fixed, and this patch is part of a clean-up of all the code that now causes the plugin to issue errors. BUG=139346 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150920

Patch Set 1 #

Patch Set 2 : GLES2_IMPL_EXPORT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -105 lines) Patch
M gpu/command_buffer/client/gles2_implementation.h View 1 1 chunk +2 lines, -16 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/query_tracker.h View 1 chunk +1 line, -10 lines 0 comments Download
M gpu/command_buffer/client/query_tracker.cc View 2 chunks +13 lines, -1 line 0 comments Download
M gpu/command_buffer/service/feature_info.h View 2 chunks +1 line, -23 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 1 chunk +7 lines, -26 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.h View 1 chunk +2 lines, -27 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 2 chunks +28 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hans
8 years, 4 months ago (2012-08-09 13:52:17 UTC) #1
greggman
lgtm
8 years, 4 months ago (2012-08-09 19:49:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/10834248/1
8 years, 4 months ago (2012-08-09 20:01:35 UTC) #3
commit-bot: I haz the power
Try job failure for 10834248-1 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-09 20:33:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/10834248/11002
8 years, 4 months ago (2012-08-09 20:45:30 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 22:31:20 UTC) #6
Change committed as 150920

Powered by Google App Engine
This is Rietveld 408576698