Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h

Issue 10834248: Clean-up inline members of nested classes (gpu/) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: GLES2_IMPL_EXPORT Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h
index 19b1e85559c858e7d2768bb0e82a4d5dcafb6d0d..fc91ce75030c15f02989f5ede71edf47c48e7d35 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h
+++ b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h
@@ -471,44 +471,25 @@ class GLES2DecoderTestBase : public testing::Test {
private:
class MockCommandBufferEngine : public CommandBufferEngine {
public:
- MockCommandBufferEngine() {
- data_.reset(new int8[kSharedBufferSize]);
- ClearSharedMemory();
- valid_buffer_.ptr = data_.get();
- valid_buffer_.size = kSharedBufferSize;
- }
+ MockCommandBufferEngine();
- virtual ~MockCommandBufferEngine() {
- }
+ virtual ~MockCommandBufferEngine();
- virtual Buffer GetSharedMemoryBuffer(int32 shm_id) OVERRIDE {
- return shm_id == kSharedMemoryId ? valid_buffer_ : invalid_buffer_;
- }
+ virtual Buffer GetSharedMemoryBuffer(int32 shm_id) OVERRIDE;
void ClearSharedMemory() {
memset(data_.get(), kInitialMemoryValue, kSharedBufferSize);
}
- virtual void set_token(int32 token) OVERRIDE {
- DCHECK(false);
- }
+ virtual void set_token(int32 token) OVERRIDE;
- virtual bool SetGetBuffer(int32 /* transfer_buffer_id */) OVERRIDE {
- DCHECK(false);
- return false;
- }
+ virtual bool SetGetBuffer(int32 /* transfer_buffer_id */) OVERRIDE;
// Overridden from CommandBufferEngine.
- virtual bool SetGetOffset(int32 offset) OVERRIDE {
- DCHECK(false);
- return false;
- }
+ virtual bool SetGetOffset(int32 offset) OVERRIDE;
// Overridden from CommandBufferEngine.
- virtual int32 GetGetOffset() OVERRIDE {
- DCHECK(false);
- return 0;
- }
+ virtual int32 GetGetOffset() OVERRIDE;
private:
scoped_array<int8> data_;
« no previous file with comments | « gpu/command_buffer/service/feature_info.cc ('k') | gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698