Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10833058: Make DownloadItem derive SupportsUserData instead of re-implementing it. (Closed)

Created:
8 years, 4 months ago by benjhayden
Modified:
8 years, 4 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, jam, achuith+watch_chromium.org, rdsmith+dwatch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Make DownloadItem derive SupportsUserData instead of re-implementing it. Reviewers: aa: webstore_installer.* Done: sky: mock_download_item.h achuith: gdata_download_observer.cc rdsmith, asanka: * Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150589

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : . #

Patch Set 4 : merge #

Total comments: 2

Patch Set 5 : include supports_user_data.h #

Total comments: 4

Patch Set 6 : gdata: "external"->"user" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -195 lines) Patch
M chrome/browser/chromeos/gdata/gdata_download_observer.cc View 1 2 3 4 5 17 chunks +39 lines, -38 lines 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/download/download_completion_blocker.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/webstore_installer.h View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/webstore_installer.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/download/download_item_impl.h View 2 chunks +0 lines, -7 lines 0 comments Download
M content/browser/download/download_item_impl.cc View 1 2 3 4 5 2 chunks +0 lines, -30 lines 0 comments Download
M content/browser/download/download_item_impl_unittest.cc View 1 1 chunk +0 lines, -67 lines 0 comments Download
M content/browser/download/download_manager_impl.cc View 1 2 3 4 4 chunks +12 lines, -11 lines 0 comments Download
M content/browser/download/download_manager_impl_unittest.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M content/public/browser/download_item.h View 4 chunks +2 lines, -24 lines 0 comments Download
M content/public/test/mock_download_item.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
benjhayden
PTAL
8 years, 4 months ago (2012-07-27 20:56:38 UTC) #1
asanka
LGTM http://codereview.chromium.org/10833058/diff/9001/chrome/browser/chromeos/gdata/gdata_download_observer.cc File chrome/browser/chromeos/gdata/gdata_download_observer.cc (right): http://codereview.chromium.org/10833058/diff/9001/chrome/browser/chromeos/gdata/gdata_download_observer.cc#newcode237 chrome/browser/chromeos/gdata/gdata_download_observer.cc:237: new GDataExternalData(gdata_path)); Nit: indent
8 years, 4 months ago (2012-08-01 16:48:06 UTC) #2
benjhayden
Thanks, Asanka! Randy, PTAL? http://codereview.chromium.org/10833058/diff/9001/chrome/browser/chromeos/gdata/gdata_download_observer.cc File chrome/browser/chromeos/gdata/gdata_download_observer.cc (right): http://codereview.chromium.org/10833058/diff/9001/chrome/browser/chromeos/gdata/gdata_download_observer.cc#newcode237 chrome/browser/chromeos/gdata/gdata_download_observer.cc:237: new GDataExternalData(gdata_path)); On 2012/08/01 16:48:06, ...
8 years, 4 months ago (2012-08-01 18:52:55 UTC) #3
Randy Smith (Not in Mondays)
lgtm
8 years, 4 months ago (2012-08-02 22:52:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benjhayden@chromium.org/10833058/2005
8 years, 4 months ago (2012-08-07 16:55:51 UTC) #5
commit-bot: I haz the power
Presubmit check for 10833058-2005 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-07 16:55:56 UTC) #6
sky
LGTM
8 years, 4 months ago (2012-08-07 17:32:08 UTC) #7
achuithb
gdata/* lgtm http://codereview.chromium.org/10833058/diff/2005/chrome/browser/chromeos/gdata/gdata_download_observer.cc File chrome/browser/chromeos/gdata/gdata_download_observer.cc (right): http://codereview.chromium.org/10833058/diff/2005/chrome/browser/chromeos/gdata/gdata_download_observer.cc#newcode61 chrome/browser/chromeos/gdata/gdata_download_observer.cc:61: class GDataExternalData : public base::SupportsUserData::Data { Shouldn't ...
8 years, 4 months ago (2012-08-07 17:43:27 UTC) #8
benjhayden
http://codereview.chromium.org/10833058/diff/2005/chrome/browser/chromeos/gdata/gdata_download_observer.cc File chrome/browser/chromeos/gdata/gdata_download_observer.cc (right): http://codereview.chromium.org/10833058/diff/2005/chrome/browser/chromeos/gdata/gdata_download_observer.cc#newcode61 chrome/browser/chromeos/gdata/gdata_download_observer.cc:61: class GDataExternalData : public base::SupportsUserData::Data { On 2012/08/07 17:43:27, ...
8 years, 4 months ago (2012-08-07 18:24:34 UTC) #9
Avi (use Gerrit)
drive-bys http://codereview.chromium.org/10833058/diff/13004/chrome/browser/chromeos/gdata/gdata_download_observer.cc File chrome/browser/chromeos/gdata/gdata_download_observer.cc (right): http://codereview.chromium.org/10833058/diff/13004/chrome/browser/chromeos/gdata/gdata_download_observer.cc#newcode31 chrome/browser/chromeos/gdata/gdata_download_observer.cc:31: // Keys for DownloadItem::ExternalData. comment out of date ...
8 years, 4 months ago (2012-08-07 19:06:24 UTC) #10
benjhayden
PTAL http://codereview.chromium.org/10833058/diff/13004/chrome/browser/chromeos/gdata/gdata_download_observer.cc File chrome/browser/chromeos/gdata/gdata_download_observer.cc (right): http://codereview.chromium.org/10833058/diff/13004/chrome/browser/chromeos/gdata/gdata_download_observer.cc#newcode31 chrome/browser/chromeos/gdata/gdata_download_observer.cc:31: // Keys for DownloadItem::ExternalData. On 2012/08/07 19:06:24, Avi ...
8 years, 4 months ago (2012-08-08 13:21:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benjhayden@chromium.org/10833058/10014
8 years, 4 months ago (2012-08-08 14:46:30 UTC) #12
commit-bot: I haz the power
Try job failure for 10833058-10014 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 4 months ago (2012-08-08 16:04:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benjhayden@chromium.org/10833058/10014
8 years, 4 months ago (2012-08-08 17:17:33 UTC) #14
commit-bot: I haz the power
8 years, 4 months ago (2012-08-08 18:18:38 UTC) #15 
Change committed as 150589

Powered by Google App Engine
This is Rietveld 408576698