Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: content/browser/download/download_manager_impl_unittest.cc

Issue 10833058: Make DownloadItem derive SupportsUserData instead of re-implementing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: gdata: "external"->"user" Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/download/download_manager_impl.cc ('k') | content/public/browser/download_item.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/download_manager_impl_unittest.cc
diff --git a/content/browser/download/download_manager_impl_unittest.cc b/content/browser/download/download_manager_impl_unittest.cc
index 545c414120d9296a2dc8923b9e310200a889e5f0..d3c7931a4bd4c3bd1f4dc25e1828b74b2b8398d3 100644
--- a/content/browser/download/download_manager_impl_unittest.cc
+++ b/content/browser/download/download_manager_impl_unittest.cc
@@ -157,9 +157,6 @@ class MockDownloadItemImpl : public DownloadItemImpl {
MOCK_METHOD0(OffThreadCancel, void());
MOCK_CONST_METHOD1(DebugString, std::string(bool));
MOCK_METHOD0(MockDownloadOpenForTesting, void());
- MOCK_METHOD1(GetExternalData, ExternalData*(const void*));
- MOCK_CONST_METHOD1(GetExternalData, const ExternalData*(const void*));
- MOCK_METHOD2(SetExternalData, void(const void*, ExternalData*));
};
class MockDownloadManagerDelegate : public content::DownloadManagerDelegate {
@@ -641,8 +638,6 @@ TEST_F(DownloadManagerTest, OnDownloadStopped_Persisted) {
MockDownloadItemImpl& item(AddItemToManager());
int download_id = item.GetId();
int64 db_handle = 0x7;
- EXPECT_CALL(item, GetExternalData(_))
- .WillOnce(Return(static_cast<DownloadItem::ExternalData*>(NULL)));
EXPECT_CALL(GetMockObserver(), ModelChanged(download_manager_.get()))
.WillOnce(Return());
AddItemToHistory(item, db_handle);
« no previous file with comments | « content/browser/download/download_manager_impl.cc ('k') | content/public/browser/download_item.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698