Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Unified Diff: content/browser/download/download_item_impl.h

Issue 10833058: Make DownloadItem derive SupportsUserData instead of re-implementing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: gdata: "external"->"user" Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/webstore_installer.cc ('k') | content/browser/download/download_item_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/download_item_impl.h
diff --git a/content/browser/download/download_item_impl.h b/content/browser/download/download_item_impl.h
index 1b4a33434550b7ad91f83c256681026ffe7dc835..593fc4667d269b999e5cb4495856d409afa49911 100644
--- a/content/browser/download/download_item_impl.h
+++ b/content/browser/download/download_item_impl.h
@@ -195,9 +195,6 @@ class CONTENT_EXPORT DownloadItemImpl : public content::DownloadItem {
virtual FilePath GetUserVerifiedFilePath() const OVERRIDE;
virtual std::string DebugString(bool verbose) const OVERRIDE;
virtual void MockDownloadOpenForTesting() OVERRIDE;
- virtual ExternalData* GetExternalData(const void* key) OVERRIDE;
- virtual const ExternalData* GetExternalData(const void* key) const OVERRIDE;
- virtual void SetExternalData(const void* key, ExternalData* data) OVERRIDE;
private:
// Construction common to all constructors. |active| should be true for new
@@ -404,10 +401,6 @@ class CONTENT_EXPORT DownloadItemImpl : public content::DownloadItem {
// Did the delegate delay calling Complete on this download?
bool delegate_delayed_complete_;
- // External Data storage. All objects in the store
- // are owned by the DownloadItemImpl.
- std::map<const void*, ExternalData*> external_data_map_;
-
// Net log to use for this download.
const net::BoundNetLog bound_net_log_;
« no previous file with comments | « chrome/browser/extensions/webstore_installer.cc ('k') | content/browser/download/download_item_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698