Issue 10832412: [content shell] create a central WebKitTestController object that manages the test cycle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10832412: [content shell] create a central WebKitTestController object that manages the test cycle (Closed)

Created:
8 years, 4 months ago by jochen (gone - plz use gerrit)

Modified:
8 years, 4 months ago

Reviewers:
marja

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[content shell] create a central WebKitTestController object that manages the test cycle Also, this introduces the concept of a main window which is reused across tests Before, each window had it's own test runner (which now merely forwards to the controller), which could result into the wrong window being dumped, or a setting being set on one window, but queried from another window BUG=111316 TEST=manually Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152600

Patch Set 1 #

Patch Set 2 : patch for landing #

Patch Set 3 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+209 lines, -112 lines)			Patch
M	content/shell/shell_browser_main.cc	View		3 chunks	+8 lines, -16 lines	0 comments	Download
M	content/shell/shell_javascript_dialog_creator.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	content/shell/webkit_test_runner_host.h	View	1 2	2 chunks	+65 lines, -23 lines	0 comments	Download
M	content/shell/webkit_test_runner_host.cc	View	1	5 chunks	+135 lines, -70 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

marja

LGTM as "can't see anything wrong" (except the build errors).

8 years, 4 months ago (2012-08-21 14:06:03 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/10832412/7001

8 years, 4 months ago (2012-08-21 15:40:25 UTC) #3

Change committed as 152600

Expand Messages | Collapse Messages