content/shell/shell_javascript_dialog_creator.cc - Issue 10832412: [content shell] create a central WebKitTestController object that manages the test cycle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/shell_javascript_dialog_creator.cc

Issue 10832412: [content shell] create a central WebKitTestController object that manages the test cycle (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/shell/shell_javascript_dialog_creator.cc

diff --git a/content/shell/shell_javascript_dialog_creator.cc b/content/shell/shell_javascript_dialog_creator.cc

index e7f0b779093bbdf7d717a4f3d33b77b0a6bb055c..60a923c500b0da656948591c9096ba861f3d38cf 100644

--- a/content/shell/shell_javascript_dialog_creator.cc

+++ b/content/shell/shell_javascript_dialog_creator.cc

@@ -87,9 +87,7 @@ void ShellJavaScriptDialogCreator::RunBeforeUnloadDialog(

const DialogClosedCallback& callback) {

if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kDumpRenderTree)) {

printf("CONFIRM NAVIGATION: %s\n", UTF16ToUTF8(message_text).c_str());

- WebKitTestRunnerHost* controller =

- WebKitTestRunnerHost::FromRenderViewHost(

- web_contents->GetRenderViewHost());

+ WebKitTestController* controller = WebKitTestController::Get();

callback.Run(

!controller->should_stay_on_page_after_handling_before_unload(),

string16());

« no previous file with comments | « content/shell/shell_browser_main.cc ('k') | content/shell/webkit_test_runner_host.h » ('j') | no next file with comments »