content/public/browser/devtools_http_handler.h - Issue 10832112: Simplify devtools code on android and enable devtools for android content_shell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/devtools_http_handler.h

Issue 10832112: Simplify devtools code on android and enable devtools for android content_shell. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/debugger/devtools_http_handler_impl.cc ('K') | « content/public/browser/android/devtools_server.h ('k') | content/shell/shell_browser_main_parts.cc » ('j') | content/shell/shell_browser_main_parts.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/devtools_http_handler.h

diff --git a/content/public/browser/devtools_http_handler.h b/content/public/browser/devtools_http_handler.h

index 8ba316c3d97f764f974097570b0f83034fb45002..22dbfafccaee33888eee003daaa2560b7f3b8653 100644

--- a/content/public/browser/devtools_http_handler.h

+++ b/content/public/browser/devtools_http_handler.h

@@ -9,6 +9,10 @@

#include "content/common/content_export.h"

+#if defined(OS_ANDROID)

pfeldman 2012/08/02 17:05:50 I don't think it should contain Android-specifics.

+#include <pwd.h>

mnaganov (inactive) 2012/08/02 16:16:45 <pwd.h> should go before <string>: http://google-s

+#endif

namespace net {

class StreamListenSocketFactory;

class URLRequestContextGetter;

@@ -48,6 +52,10 @@ class DevToolsHttpHandler {

net::URLRequestContextGetter* request_context_getter,

DevToolsHttpHandlerDelegate* delegate);

+#if defined(OS_ANDROID)

+ CONTENT_EXPORT static bool IsUserAllowedToConnect(uid_t uid, gid_t gid);

+#endif

// Called from the main thread in order to stop protocol handler.

// Automatically destroys the handler instance.

virtual void Stop() = 0;