Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Side by Side Diff: content/public/browser/devtools_http_handler.h

Issue 10832112: Simplify devtools code on android and enable devtools for android content_shell. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_DEVTOOLS_HTTP_HANDLER_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_DEVTOOLS_HTTP_HANDLER_H_
6 #define CONTENT_PUBLIC_BROWSER_DEVTOOLS_HTTP_HANDLER_H_ 6 #define CONTENT_PUBLIC_BROWSER_DEVTOOLS_HTTP_HANDLER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "content/common/content_export.h" 10 #include "content/common/content_export.h"
11 11
12 #if defined(OS_ANDROID)
pfeldman 2012/08/02 17:05:50 I don't think it should contain Android-specifics.
13 #include <pwd.h>
mnaganov (inactive) 2012/08/02 16:16:45 <pwd.h> should go before <string>: http://google-s
14 #endif
15
12 namespace net { 16 namespace net {
13 class StreamListenSocketFactory; 17 class StreamListenSocketFactory;
14 class URLRequestContextGetter; 18 class URLRequestContextGetter;
15 } 19 }
16 20
17 namespace content { 21 namespace content {
18 22
19 class DevToolsHttpHandlerDelegate; 23 class DevToolsHttpHandlerDelegate;
20 class RenderViewHost; 24 class RenderViewHost;
21 25
(...skipping 19 matching lines...) Expand all
41 CONTENT_EXPORT static int GetFrontendResourceId( 45 CONTENT_EXPORT static int GetFrontendResourceId(
42 const std::string& name); 46 const std::string& name);
43 47
44 // Takes ownership over |socket_factory| and |delegate|. 48 // Takes ownership over |socket_factory| and |delegate|.
45 CONTENT_EXPORT static DevToolsHttpHandler* Start( 49 CONTENT_EXPORT static DevToolsHttpHandler* Start(
46 const net::StreamListenSocketFactory* socket_factory, 50 const net::StreamListenSocketFactory* socket_factory,
47 const std::string& frontend_url, 51 const std::string& frontend_url,
48 net::URLRequestContextGetter* request_context_getter, 52 net::URLRequestContextGetter* request_context_getter,
49 DevToolsHttpHandlerDelegate* delegate); 53 DevToolsHttpHandlerDelegate* delegate);
50 54
55 #if defined(OS_ANDROID)
56 CONTENT_EXPORT static bool IsUserAllowedToConnect(uid_t uid, gid_t gid);
57 #endif
58
51 // Called from the main thread in order to stop protocol handler. 59 // Called from the main thread in order to stop protocol handler.
52 // Automatically destroys the handler instance. 60 // Automatically destroys the handler instance.
53 virtual void Stop() = 0; 61 virtual void Stop() = 0;
54 62
55 // Set the RenderViewHostBinding instance. If no instance is provided the 63 // Set the RenderViewHostBinding instance. If no instance is provided the
56 // default implementation will be used. 64 // default implementation will be used.
57 virtual void SetRenderViewHostBinding(RenderViewHostBinding* binding) = 0; 65 virtual void SetRenderViewHostBinding(RenderViewHostBinding* binding) = 0;
58 66
59 protected: 67 protected:
60 virtual ~DevToolsHttpHandler() {} 68 virtual ~DevToolsHttpHandler() {}
61 }; 69 };
62 70
63 } // namespace content 71 } // namespace content
64 72
65 #endif // CONTENT_PUBLIC_BROWSER_DEVTOOLS_HTTP_HANDLER_H_ 73 #endif // CONTENT_PUBLIC_BROWSER_DEVTOOLS_HTTP_HANDLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698