Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: content/shell/shell_browser_main_parts.cc

Issue 10832112: Simplify devtools code on android and enable devtools for android content_shell. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/shell_browser_main_parts.cc
diff --git a/content/shell/shell_browser_main_parts.cc b/content/shell/shell_browser_main_parts.cc
index b8ba066f32abb610032b004f9c3d70bacb75eee2..7ea17282c268b20ae84719a1b5938605ab8564a1 100644
--- a/content/shell/shell_browser_main_parts.cc
+++ b/content/shell/shell_browser_main_parts.cc
@@ -80,6 +80,11 @@ void ShellBrowserMainParts::PreMainMessageLoopRun() {
Shell::PlatformInitialize();
net::NetModule::SetResourceProvider(Shell::PlatformResourceProvider);
+#if defined(OS_ANDROID)
+ devtools_delegate_ = new ShellDevToolsDelegate(
pfeldman 2012/08/02 17:05:50 So you want to always have remote debugging-enable
Satish 2012/08/02 17:17:53 For content shell, yes because it is aimed towards
pfeldman 2012/08/02 17:37:53 Sounds good.
+ 0, // On android the port number isn't used.
+ browser_context_->GetRequestContext());
+#else
const CommandLine& command_line = *CommandLine::ForCurrentProcess();
if (command_line.HasSwitch(switches::kRemoteDebuggingPort)) {
std::string port_str =
@@ -93,6 +98,7 @@ void ShellBrowserMainParts::PreMainMessageLoopRun() {
DLOG(WARNING) << "Invalid http debugger port number " << port;
}
}
+#endif
if (!CommandLine::ForCurrentProcess()->HasSwitch(switches::kDumpRenderTree)) {
Shell::CreateNewWindow(browser_context_.get(),

Powered by Google App Engine
This is Rietveld 408576698