Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 10831138: Remove a ton of IPC from landing putWithIndexKeys (Closed)

Created:
8 years, 4 months ago by alecflett
Modified:
8 years, 4 months ago
Reviewers:
dgrogan, jsbell
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove a ton of IPC from landing putWithIndexKeys This removes a whole bunch of IPC stubs for methods that don't exist anymore: IDBCursorBackendInterface::update IDBObjectStoreBackendInterface::put IDBTransaction::mode BUG=129471 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149731

Patch Set 1 #

Patch Set 2 : Additional stuff found with lint #

Total comments: 2

Messages

Total messages: 5 (0 generated)
alecflett
I was cleaning up after myself.. and found a few other issues while I was ...
8 years, 4 months ago (2012-08-02 19:48:50 UTC) #1
dgrogan
lgtm https://chromiumcodereview.appspot.com/10831138/diff/2001/content/browser/in_process_webkit/indexed_db_dispatcher_host.cc File content/browser/in_process_webkit/indexed_db_dispatcher_host.cc (left): https://chromiumcodereview.appspot.com/10831138/diff/2001/content/browser/in_process_webkit/indexed_db_dispatcher_host.cc#oldcode64 content/browser/in_process_webkit/indexed_db_dispatcher_host.cc:64: Lint told you to remove this line? Should ...
8 years, 4 months ago (2012-08-02 20:27:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/10831138/2001
8 years, 4 months ago (2012-08-02 21:24:02 UTC) #3
alecflett
https://chromiumcodereview.appspot.com/10831138/diff/2001/content/browser/in_process_webkit/indexed_db_dispatcher_host.cc File content/browser/in_process_webkit/indexed_db_dispatcher_host.cc (left): https://chromiumcodereview.appspot.com/10831138/diff/2001/content/browser/in_process_webkit/indexed_db_dispatcher_host.cc#oldcode64 content/browser/in_process_webkit/indexed_db_dispatcher_host.cc:64: On 2012/08/02 20:27:32, dgrogan wrote: > Lint told you ...
8 years, 4 months ago (2012-08-02 21:25:05 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-02 23:11:11 UTC) #5
Change committed as 149731

Powered by Google App Engine
This is Rietveld 408576698