Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1453)

Unified Diff: content/common/indexed_db/proxy_webidbcursor_impl.cc

Issue 10831138: Remove a ton of IPC from landing putWithIndexKeys (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Additional stuff found with lint Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/indexed_db/proxy_webidbcursor_impl.cc
diff --git a/content/common/indexed_db/proxy_webidbcursor_impl.cc b/content/common/indexed_db/proxy_webidbcursor_impl.cc
index 5dd62bd8d665a8b30c945134f0d27c98790e4111..adf3ae015beb97fb01dc7c005edcd719eb0dc3d8 100644
--- a/content/common/indexed_db/proxy_webidbcursor_impl.cc
+++ b/content/common/indexed_db/proxy_webidbcursor_impl.cc
@@ -4,6 +4,8 @@
#include "content/common/indexed_db/proxy_webidbcursor_impl.h"
+#include <vector>
+
#include "content/common/child_thread.h"
#include "content/common/indexed_db/indexed_db_messages.h"
#include "content/common/indexed_db/indexed_db_dispatcher.h"
@@ -47,15 +49,6 @@ WebSerializedScriptValue RendererWebIDBCursorImpl::value() const {
return value_;
}
-void RendererWebIDBCursorImpl::update(const WebSerializedScriptValue& value,
- WebIDBCallbacks* callbacks,
- WebExceptionCode& ec) {
- IndexedDBDispatcher* dispatcher =
- IndexedDBDispatcher::ThreadSpecificInstance();
- dispatcher->RequestIDBCursorUpdate(
- SerializedScriptValue(value), callbacks, idb_cursor_id_, &ec);
-}
-
void RendererWebIDBCursorImpl::advance(unsigned long count,
WebIDBCallbacks* callbacks_ptr,
WebExceptionCode& ec) {
@@ -150,7 +143,7 @@ void RendererWebIDBCursorImpl::SetPrefetchData(
void RendererWebIDBCursorImpl::CachedContinue(
WebKit::WebIDBCallbacks* callbacks) {
- DCHECK(prefetch_keys_.size() > 0);
+ DCHECK_GT(prefetch_keys_.size(), 0ul);
DCHECK(prefetch_primary_keys_.size() == prefetch_keys_.size());
DCHECK(prefetch_values_.size() == prefetch_keys_.size());

Powered by Google App Engine
This is Rietveld 408576698