Issue 10831108: mac: Fix a few compile errors with the 10.8 SDK

Issue 10831108: mac: Fix a few compile errors with the 10.8 SDK (Closed)

Created:
8 years, 4 months ago by Nico

Modified:
8 years, 4 months ago

Reviewers:
Robert Sesek, tony, Avi (use Gerrit), Jamie

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, sergeyu+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, wez+watch_chromium.org, lambroslambrou+watch_chromium.org, darin-cc_chromium.org, pam+watch_chromium.org, alexeypa+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

mac: Fix a few compile errors with the 10.8 SDK BUG=139138 TBR=tony Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149465

Patch Set 1 #

Total comments: 4

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -12 lines)			Patch
M	chrome/browser/ui/website_settings/website_settings_unittest.cc	View	6 chunks	+7 lines, -6 lines	0 comments	Download
M	remoting/host/installer/mac/uninstaller/remoting_uninstaller_app.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell_mac.mm	View	1 chunk	+5 lines, -4 lines	1 comment	Download
M	webkit/tools/test_shell/test_webview_delegate_mac.mm	View	1 chunk	+1 line, -1 line	3 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

LGTM https://chromiumcodereview.appspot.com/10831108/diff/1/webkit/tools/test_shell/test_shell_mac.mm File webkit/tools/test_shell/test_shell_mac.mm (right): https://chromiumcodereview.appspot.com/10831108/diff/1/webkit/tools/test_shell/test_shell_mac.mm#newcode557 webkit/tools/test_shell/test_shell_mac.mm:557: [save_panel setAllowedFileTypes:@[@"txt"]]; Snazzy. https://chromiumcodereview.appspot.com/10831108/diff/1/webkit/tools/test_shell/test_webview_delegate_mac.mm File webkit/tools/test_shell/test_webview_delegate_mac.mm (right): https://chromiumcodereview.appspot.com/10831108/diff/1/webkit/tools/test_shell/test_webview_delegate_mac.mm#newcode272 ...

8 years, 4 months ago (2012-08-01 15:22:30 UTC) #2

Avi (use Gerrit)

https://chromiumcodereview.appspot.com/10831108/diff/1/webkit/tools/test_shell/test_webview_delegate_mac.mm File webkit/tools/test_shell/test_webview_delegate_mac.mm (right): https://chromiumcodereview.appspot.com/10831108/diff/1/webkit/tools/test_shell/test_webview_delegate_mac.mm#newcode272 webkit/tools/test_shell/test_webview_delegate_mac.mm:272: informativeTextWithFormat:@"%@", text]; Because the call is "format", so you ...

8 years, 4 months ago (2012-08-01 15:25:29 UTC) #3

Nico

thanks! https://chromiumcodereview.appspot.com/10831108/diff/1/webkit/tools/test_shell/test_webview_delegate_mac.mm File webkit/tools/test_shell/test_webview_delegate_mac.mm (right): https://chromiumcodereview.appspot.com/10831108/diff/1/webkit/tools/test_shell/test_webview_delegate_mac.mm#newcode272 webkit/tools/test_shell/test_webview_delegate_mac.mm:272: informativeTextWithFormat:@"%@", text]; On 2012/08/01 15:25:29, Avi wrote: > ...

8 years, 4 months ago (2012-08-01 15:39:18 UTC) #4

markusheintz_

On 2012/08/01 15:40:14, Nico wrote: > jamiewalch, tony: OWNERS stamp please LGTM website_settings stuff

8 years, 4 months ago (2012-08-01 15:50:20 UTC) #6

markusheintz_

On 2012/08/01 15:40:14, Nico wrote: > jamiewalch, tony: OWNERS stamp please LGTM website_settings stuff

8 years, 4 months ago (2012-08-01 15:50:21 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10831108/1

8 years, 4 months ago (2012-08-01 17:54:35 UTC) #9

rs LGTM

Expand Messages | Collapse Messages