mac: Fix a few compile errors with the 10.8 SDK

webkit/tools/test_shell/test_webview_delegate_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/tools/test_shell/test_webview_delegate.h"
 
 #import <Cocoa/Cocoa.h>
 #include "base/sys_string_conversions.h"
 #include "base/utf_string_conversions.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebCursorInfo.h"
@@ skipping 251 matching lines @@
 
 // Private methods ------------------------------------------------------------
 
 void TestWebViewDelegate::ShowJavaScriptAlert(const string16& message) {
   NSString *text =
       [NSString stringWithUTF8String:UTF16ToUTF8(message).c_str()];
   NSAlert *alert = [NSAlert alertWithMessageText:@"JavaScript Alert"
                                    defaultButton:@"OK"
                                  alternateButton:nil
                                      otherButton:nil
-                       informativeTextWithFormat:text];
+                       informativeTextWithFormat:@"%@", text];

[Robert Sesek, 2012/08/01 15:22:30]

Why this change?

[Avi (use Gerrit), 2012/08/01 15:25:29]

Because the call is "format", so you need a format string. Clang probably warns
since passing user input as format strings is a huge cause of security holes.

http://www.cs.berkeley.edu/~daw/papers/fmtstr-plas07.pdf

[Nico, 2012/08/01 15:39:19]

Right. The 10.8 headers probably add __attribute__((format(printf,5,6))) to this
function.

   [alert runModal];
 }
 
 void TestWebViewDelegate::SetPageTitle(const string16& title) {
   [[shell_->webViewHost()->view_handle() window]
       setTitle:[NSString stringWithUTF8String:UTF16ToUTF8(title).c_str()]];
 }
 
 void TestWebViewDelegate::SetAddressBarURL(const GURL& url) {
   const char* frameURL = url.spec().c_str();
   NSString *address = [NSString stringWithUTF8String:frameURL];
   [shell_->editWnd() setStringValue:address];
 }