mac: Fix a few compile errors with the 10.8 SDK

webkit/tools/test_shell/test_webview_delegate_mac.mm

Index: webkit/tools/test_shell/test_webview_delegate_mac.mm
diff --git a/webkit/tools/test_shell/test_webview_delegate_mac.mm b/webkit/tools/test_shell/test_webview_delegate_mac.mm
index cd05eeef632a3c8dcf6b5c15f2e27a35f10294a9..4cc08578392084993dfa195f9a6208e0a9dd2774 100644
--- a/webkit/tools/test_shell/test_webview_delegate_mac.mm
+++ b/webkit/tools/test_shell/test_webview_delegate_mac.mm
@@ -269,7 +269,7 @@ void TestWebViewDelegate::ShowJavaScriptAlert(const string16& message) {
                                    defaultButton:@"OK"
                                  alternateButton:nil
                                      otherButton:nil
-                       informativeTextWithFormat:text];
+                       informativeTextWithFormat:@"%@", text];

[Robert Sesek, 2012/08/01 15:22:30]

Why this change?

[Avi (use Gerrit), 2012/08/01 15:25:29]

Because the call is "format", so you need a format string. Clang probably warns
since passing user input as format strings is a huge cause of security holes.

http://www.cs.berkeley.edu/~daw/papers/fmtstr-plas07.pdf

[Nico, 2012/08/01 15:39:19]

Right. The 10.8 headers probably add __attribute__((format(printf,5,6))) to this
function.

   [alert runModal];
 }