src/trusted/service_runtime/arch/x86_32/springboard.S - Issue 10829110: Fix two register leaks in the trusted->untrusted context switch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/service_runtime/arch/x86_32/springboard.S

Issue 10829110: Fix two register leaks in the trusted->untrusted context switch (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Fix comment Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « src/trusted/service_runtime/arch/arm/nacl_switch.S ('k') | src/trusted/service_runtime/arch/x86_64/nacl_switch_64.S » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/trusted/service_runtime/arch/x86_32/springboard.S

diff --git a/src/trusted/service_runtime/arch/x86_32/springboard.S b/src/trusted/service_runtime/arch/x86_32/springboard.S

index 03eb0dd259611b53fa9992a9a15aca145b6fb04e..c88199dabba4b1f8164a1f3dd5890391824b697d 100644

--- a/src/trusted/service_runtime/arch/x86_32/springboard.S

+++ b/src/trusted/service_runtime/arch/x86_32/springboard.S

@@ -29,6 +29,8 @@ DEFINE_GLOBAL_HIDDEN_IDENTIFIER(NaCl_springboard):

mov NACL_THREAD_CONTEXT_OFFSET_SYSRET(%ecx), %eax

lss NACL_THREAD_CONTEXT_OFFSET_STACK_PTR(%ecx), %esp

movw NACL_THREAD_CONTEXT_OFFSET_DS(%ecx), %ds

+ /* Set %ecx to zero to avoid leaking the NaClThreadContext address */

+ xorl %ecx, %ecx

jmp *%edx

DEFINE_GLOBAL_HIDDEN_IDENTIFIER(NaCl_springboard_end):

« no previous file with comments | « src/trusted/service_runtime/arch/arm/nacl_switch.S ('k') | src/trusted/service_runtime/arch/x86_64/nacl_switch_64.S » ('j') | no next file with comments »