src/trusted/service_runtime/arch/arm/nacl_switch.S - Issue 10829110: Fix two register leaks in the trusted->untrusted context switch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/service_runtime/arch/arm/nacl_switch.S

Issue 10829110: Fix two register leaks in the trusted->untrusted context switch (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Fix comment Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/trusted/service_runtime/arch/arm/nacl_switch.S

diff --git a/src/trusted/service_runtime/arch/arm/nacl_switch.S b/src/trusted/service_runtime/arch/arm/nacl_switch.S

index 68dc305cab1b9906e0250218f4fb871e91697aaa..04b703c3ad32501a3bad6a67e841f73d4865aa69 100644

--- a/src/trusted/service_runtime/arch/arm/nacl_switch.S

+++ b/src/trusted/service_runtime/arch/arm/nacl_switch.S

@@ -22,13 +22,14 @@

DEFINE_GLOBAL_HIDDEN_IDENTIFIER(NaClSwitch):

- * We clear registers r2, r3, lr, flag and status fields in CPSR

- * (status register) to avoid information leaks. The remaining

+ * We clear registers r2, r3, r12 (ip), lr, flag and status fields in

+ * CPSR (status register) to avoid information leaks. The remaining

* registers are overwritten by the code that follows after.

mov r2, #0

mov r3, #0

+ mov r12, #0

mov lr, #0

msr cpsr_fs, #0

« no previous file with comments | « SConstruct ('k') | src/trusted/service_runtime/arch/x86_32/springboard.S » ('j') | no next file with comments »