src/trusted/service_runtime/arch/x86_64/nacl_switch_64.S - Issue 10829110: Fix two register leaks in the trusted->untrusted context switch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/service_runtime/arch/x86_64/nacl_switch_64.S

Issue 10829110: Fix two register leaks in the trusted->untrusted context switch (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Fix comment Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « src/trusted/service_runtime/arch/x86_32/springboard.S ('k') | src/trusted/service_runtime/arch/x86_64/nacl_syscall_64.S » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/trusted/service_runtime/arch/x86_64/nacl_switch_64.S

diff --git a/src/trusted/service_runtime/arch/x86_64/nacl_switch_64.S b/src/trusted/service_runtime/arch/x86_64/nacl_switch_64.S

index a46d8dafe8d72d4b396929afd1e48d0f898a6c9e..772fa31a5c269aef845975b5fa5328dfc459846c 100644

--- a/src/trusted/service_runtime/arch/x86_64/nacl_switch_64.S

+++ b/src/trusted/service_runtime/arch/x86_64/nacl_switch_64.S

@@ -96,6 +96,9 @@ MACROENTRY

* are a byte shorter than their 64-bit counterparts

* when the target register is one of the first eight,

* and they implicitly zero the high halves.

+ *

+ * The 'xorl' instruction also resets most flags to known

+ * values.

xorl %edx, %edx

movl %edx, %esi

« no previous file with comments | « src/trusted/service_runtime/arch/x86_32/springboard.S ('k') | src/trusted/service_runtime/arch/x86_64/nacl_syscall_64.S » ('j') | no next file with comments »