Context menus for text fields in platform apps should show available actions (copy, paste, etc).

Context menus for text fields in platform apps should show available actions (copy, paste, etc).

BUG=143312
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153611

[asargent_no_longer_on_chrome, 2012-08-20 19:40:21]

https://chromiumcodereview.appspot.com/10828392/diff/1/chrome/browser/tab_con...
File chrome/browser/tab_contents/render_view_context_menu.cc (right):

https://chromiumcodereview.appspot.com/10828392/diff/1/chrome/browser/tab_con...
chrome/browser/tab_contents/render_view_context_menu.cc:663: }
I think we also want to add the copy menu command via AppendCopyItem() for cases
where there is a selection (similar to what we do in
RenderViewContextMenu::InitMenu).

Also, I wonder if we should move this code *above* the call to
AppendExtensionItems on line 656, since the order for normal browser windows
with extension items is that the system-provided items go first, then the
extension ones. Let's ask Mihai for his opinion.

[Marijn Kruisselbrink, 2012-08-20 19:46:57]

https://chromiumcodereview.appspot.com/10828392/diff/1/chrome/browser/tab_con...
File chrome/browser/tab_contents/render_view_context_menu.cc (right):

https://chromiumcodereview.appspot.com/10828392/diff/1/chrome/browser/tab_con...
chrome/browser/tab_contents/render_view_context_menu.cc:663: }
On 2012/08/20 19:40:21, Antony Sargent wrote:
> I think we also want to add the copy menu command via AppendCopyItem() for
cases
> where there is a selection (similar to what we do in
> RenderViewContextMenu::InitMenu).
I thought about that, but as far as I could tell in platform apps it's not
actually possible to select text (other than in text fields, which is handled by
is_editable even if the field is read-only). But I guess it wouldn't hurt to add
it anyway.

> Also, I wonder if we should move this code *above* the call to
> AppendExtensionItems on line 656, since the order for normal browser windows
> with extension items is that the system-provided items go first, then the
> extension ones. Let's ask Mihai for his opinion. 
One other thing about order of the items I was wondering about is the
reload&developer items; currently the menu has [extension items, reload,
separator, developer items], while I think it would be nicer if there would
between extension items and any other menu items (so moving reload after the
developer items would accomplish that).

[asargent_no_longer_on_chrome, 2012-08-20 20:30:20]

> I thought about that, but as far as I could tell in platform apps it's
> not actually possible to select text (other than in text fields, which
> is handled by is_editable even if the field is read-only). But I guess
> it wouldn't hurt to add it anyway.



We use a different default css stylesheet for platform apps that among
other things makes text non-selectable by default, but developers can
always override that. The css property is "-webkit-user-select" ;
apparently this is a relatively new css feature so its name is still behind
a vendor prefix, but it looks like it's being standardized:
http://www.w3.org/TR/2000/WD-css3-userint-20000216#user-select




>
>  Also, I wonder if we should move this code *above* the call to
>> AppendExtensionItems on line 656, since the order for normal browser
>>
> windows
>
>> with extension items is that the system-provided items go first, then
>>
> the
>
>> extension ones. Let's ask Mihai for his opinion.
>>
> One other thing about order of the items I was wondering about is the
> reload&developer items; currently the menu has [extension items, reload,
> separator, developer items], while I think it would be nicer if there
> would between extension items and any other menu items (so moving reload
> after the developer items would accomplish that).
>
>
https://chromiumcodereview.**appspot.com/10828392/<https://chromiumcodereview...



Reload and the developer items are only present in "unpacked" developer
mode, not if you've installed from a .crx (for example via the webstore),
so regular users should never see them. That being said, I think keeping
them in the same order as other non-app chrome windows is desirable from a
"muscle memory" standpoint for developers.

[Marijn Kruisselbrink, 2012-08-24 16:45:16]

okay, added copy item when there is a selection

[asargent_no_longer_on_chrome, 2012-08-24 21:42:34]

LGTM

[brettw, 2012-08-27 19:16:58]

lgtm

[commit-bot: I haz the power, 2012-08-28 00:17:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mek@chromium.org/10828392/5002

[commit-bot: I haz the power, 2012-08-28 02:43:51]

Change committed as 153611