Context menus for text fields in platform apps should show available actions (copy, paste, etc).

chrome/browser/tab_contents/render_view_context_menu.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <set>
 #include <utility>
 
 #include "chrome/browser/tab_contents/render_view_context_menu.h"
 
@@ skipping 637 matching lines @@
 }
 
 void RenderViewContextMenu::AppendPlatformAppItems() {
   const Extension* platform_app = GetExtension();
   DCHECK(platform_app);
   DCHECK(platform_app->is_platform_app());
 
   int index = 0;
   AppendExtensionItems(platform_app->id(), &index);
 
+  // Add undo/redo, cut/copy/paste etc for text fields
+  if (params_.is_editable) {
+    if (menu_model_.GetItemCount() > 0)
+      menu_model_.AddSeparator();
+    AppendEditableItems();
+  }

[asargent_no_longer_on_chrome, 2012/08/20 19:40:21]

I think we also want to add the copy menu command via AppendCopyItem() for cases
where there is a selection (similar to what we do in
RenderViewContextMenu::InitMenu).

Also, I wonder if we should move this code *above* the call to
AppendExtensionItems on line 656, since the order for normal browser windows
with extension items is that the system-provided items go first, then the
extension ones. Let's ask Mihai for his opinion. 

[Marijn Kruisselbrink, 2012/08/20 19:46:58]

I thought about that, but as far as I could tell in platform apps it's not
actually possible to select text (other than in text fields, which is handled by
is_editable even if the field is read-only). But I guess it wouldn't hurt to add
it anyway.
One other thing about order of the items I was wondering about is the
reload&developer items; currently the menu has [extension items, reload,
separator, developer items], while I think it would be nicer if there would
between extension items and any other menu items (so moving reload after the
developer items would accomplish that).

+
   // Add dev tools for unpacked extensions.
   if (platform_app->location() == Extension::LOAD) {
     menu_model_.AddItemWithStringId(IDC_RELOAD, IDS_CONTENT_CONTEXT_RELOAD);
     AppendDeveloperItems();
   }
 }
 
 void RenderViewContextMenu::AppendPopupExtensionItems() {
   bool has_selection = !params_.selection_text.empty();
 
@@ skipping 1341 matching lines @@
   source_web_contents_->GetRenderViewHost()->
       ExecuteMediaPlayerActionAtLocation(location, action);
 }
 
 void RenderViewContextMenu::PluginActionAt(
     const gfx::Point& location,
     const WebPluginAction& action) {
   source_web_contents_->GetRenderViewHost()->
       ExecutePluginActionAtLocation(location, action);
 }