chrome/browser/tab_contents/render_view_context_menu.cc - Issue 10828392: Context menus for text fields in platform apps should show available actions (copy, paste, etc).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/render_view_context_menu.cc

Issue 10828392: Context menus for text fields in platform apps should show available actions (copy, paste, etc). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix conflicts Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/platform_app_browsertest.cc ('k') | chrome/test/data/extensions/platform_apps/context_menu/test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/tab_contents/render_view_context_menu.cc

diff --git a/chrome/browser/tab_contents/render_view_context_menu.cc b/chrome/browser/tab_contents/render_view_context_menu.cc

index ed85888419c8796d34acedf1fc8f754c03561c40..f519aa054fff89bbd508eb7713b21d8efde0aa88 100644

--- a/chrome/browser/tab_contents/render_view_context_menu.cc

+++ b/chrome/browser/tab_contents/render_view_context_menu.cc

@@ -658,6 +658,14 @@ void RenderViewContextMenu::AppendPlatformAppItems() {

DCHECK(platform_app);

DCHECK(platform_app->is_platform_app());

+ bool has_selection = !params_.selection_text.empty();

+ // Add undo/redo, cut/copy/paste etc for text fields

+ if (params_.is_editable)

+ AppendEditableItems();

+ else if (has_selection)

+ AppendCopyItem();

int index = 0;

AppendExtensionItems(platform_app->id(), &index);