Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 10827326: gdata: Make callback parameter mandatory for GetEntryInfo family (Closed)

Created:
8 years, 4 months ago by satorux1
Modified:
8 years, 4 months ago
Reviewers:
achuithb
CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

gdata: Make callback parameter mandatory for GetEntryInfo family Looking at callers, it's safe to make the callback parameter mandatory for GetEntryInfoByResourceId(), GetEntryInfoByPath(), ReadDirectoryByPath(), as well as helper functions that implement these. After all these functions are used to get information asynchronously, hence it does not make sense to call them without the callback parameter. BUG=126634 TEST=out/Release/unit_tests --gtest_filter=GData* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151558

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -12 lines) Patch
M chrome/browser/chromeos/gdata/gdata_file_system.h View 4 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_file_system.cc View 12 chunks +21 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_file_system_interface.h View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
satorux1
8 years, 4 months ago (2012-08-14 17:41:29 UTC) #1
achuithb
8 years, 4 months ago (2012-08-14 18:16:04 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698