Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3765)

Unified Diff: chrome/browser/chromeos/gdata/gdata_file_system_interface.h

Issue 10827326: gdata: Make callback parameter mandatory for GetEntryInfo family (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/gdata/gdata_file_system.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/gdata/gdata_file_system_interface.h
diff --git a/chrome/browser/chromeos/gdata/gdata_file_system_interface.h b/chrome/browser/chromeos/gdata/gdata_file_system_interface.h
index 59568ebdc753871e364f6a19eb0c19ba35ffadc0..c61d86981fdc0985703d3f322c740f7ee12deaff 100644
--- a/chrome/browser/chromeos/gdata/gdata_file_system_interface.h
+++ b/chrome/browser/chromeos/gdata/gdata_file_system_interface.h
@@ -137,6 +137,7 @@ class GDataFileSystemInterface {
// does not initiate content refreshing.
//
// Can be called from UI/IO thread. |callback| is run on the calling thread.
+ // |callback| must not be null.
virtual void GetEntryInfoByResourceId(
const std::string& resource_id,
const GetEntryInfoWithFilePathCallback& callback) = 0;
@@ -302,6 +303,7 @@ class GDataFileSystemInterface {
// retrieve and refresh file system content from server and disk cache.
//
// Can be called from UI/IO thread. |callback| is run on the calling thread.
+ // |callback| must not be null.
virtual void GetEntryInfoByPath(const FilePath& file_path,
const GetEntryInfoCallback& callback) = 0;
@@ -309,6 +311,7 @@ class GDataFileSystemInterface {
// and refresh file system content from server and disk cache.
//
// Can be called from UI/IO thread. |callback| is run on the calling thread.
+ // |callback| must not be null.
virtual void ReadDirectoryByPath(
const FilePath& file_path,
const ReadDirectoryWithSettingCallback& callback) = 0;
« no previous file with comments | « chrome/browser/chromeos/gdata/gdata_file_system.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698