Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1708)

Unified Diff: chrome/browser/chromeos/gdata/gdata_file_system.h

Issue 10827326: gdata: Make callback parameter mandatory for GetEntryInfo family (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/gdata/gdata_file_system.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/gdata/gdata_file_system.h
diff --git a/chrome/browser/chromeos/gdata/gdata_file_system.h b/chrome/browser/chromeos/gdata/gdata_file_system.h
index e4e2f6870cdf3110729fab3f12498c18ad94990c..4ed5d121df21b3d70a76c7043726a915c0f03743 100644
--- a/chrome/browser/chromeos/gdata/gdata_file_system.h
+++ b/chrome/browser/chromeos/gdata/gdata_file_system.h
@@ -542,6 +542,7 @@ class GDataFileSystem : public GDataFileSystemInterface,
GDataEntry* entry);
// Runs the callback and notifies that the initial load is finished.
+ // |callback| must not be null.
void RunAndNotifyInitialLoadFinished(const FindEntryCallback& callback,
GDataFileError error,
GDataEntry* entry);
@@ -598,6 +599,7 @@ class GDataFileSystem : public GDataFileSystemInterface,
bool* has_enough_space);
// Helper function used to perform synchronous file search on UI thread.
+ // |callback| must not be null.
void FindEntryByPathSyncOnUIThread(const FilePath& search_file_path,
const FindEntryCallback& callback);
@@ -608,17 +610,20 @@ class GDataFileSystem : public GDataFileSystemInterface,
void InitializePreferenceObserver();
// Called when an entry is found for GetEntryInfoByPath().
+ // |callback| must not be null.
void OnGetEntryInfo(const GetEntryInfoCallback& callback,
GDataFileError error,
GDataEntry* entry);
// Called when an entry is found for ReadDirectoryByPath().
+ // |callback| must not be null.
void OnReadDirectory(const ReadDirectoryWithSettingCallback& callback,
GDataFileError error,
GDataEntry* entry);
// Finds file info by using virtual |file_path|. This call will also
// retrieve and refresh file system content from server and disk cache.
+ // |callback| must not be null.
void FindEntryByPathAsyncOnUIThread(const FilePath& search_file_path,
const FindEntryCallback& callback);
@@ -763,6 +768,7 @@ class GDataFileSystem : public GDataFileSystemInterface,
// Part of GetEntryByResourceId and GetEntryByPath. Checks whether there is a
// local dirty cache for the entry, and if there is, replace the
// PlatformFileInfo part of the |entry_proto| with the locally modified info.
+ // |callback| must not be null.
void CheckLocalModificationAndRun(scoped_ptr<GDataEntryProto> entry_proto,
const GetEntryInfoCallback& callback);
void CheckLocalModificationAndRunAfterGetCacheEntry(
« no previous file with comments | « no previous file | chrome/browser/chromeos/gdata/gdata_file_system.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698