Issue 10827176: fix duplication issue for android path_service.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10827176: fix duplication issue for android path_service.cc (Closed)

Created:
8 years, 4 months ago by Wei James(wistoch)

Modified:
8 years, 4 months ago

Reviewers:
Yaron, jar (doing other things)

CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org, yongsheng, Shouqun Liu, haitao.feng, hengzhi.wu

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

fix duplication issue for android path_service.cc For x86 android, we cannot have two files with the same basename, even they are under different folders. BUG=

Patch Set 1 #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -47 lines)			Patch
M	base/android/base_jni_registrar.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
D	base/android/path_service.h	View	1 chunk	+0 lines, -18 lines	0 comments	Download
D	base/android/path_service.cc	View	1 chunk	+0 lines, -26 lines	0 comments	Download
A +	base/android/path_service_android.h	View	0 chunks	+-1 lines, --1 lines	1 comment	Download
A +	base/android/path_service_android.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/base.gypi	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Wei James(wistoch)

jar for the owner of base/ yfriedman for the owner of base/android/. thanks

8 years, 4 months ago (2012-08-06 02:16:09 UTC) #1

Yaron

lgtm http://chromiumcodereview.appspot.com/10827176/diff/1/base/android/path_service_android.h File base/android/path_service_android.h (right): http://chromiumcodereview.appspot.com/10827176/diff/1/base/android/path_service_android.h#newcode5 base/android/path_service_android.h:5: #ifndef BASE_ANDROID_PATH_SERVICE_H_ Update header guard to BASE_ANDROID_PATH_SERVICE_ANDROID_H_

8 years, 4 months ago (2012-08-06 16:05:43 UTC) #2

jar (doing other things)

With header guard change suggested by yaron.... LGTM

8 years, 4 months ago (2012-08-06 17:23:40 UTC) #3

nilesh

8 years, 4 months ago (2012-08-06 20:42:38 UTC) #4

On 2012/08/06 17:23:40, jar wrote:
> With header guard change suggested by yaron....
> 
> LGTM

Already done in: https://chromiumcodereview.appspot.com/10828152/

Expand Messages | Collapse Messages