Issue 10828152: Move base/android/path_service.cc|h to path_service_android.cc|h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10828152: Move base/android/path_service.cc|h to path_service_android.cc|h (Closed)

Created:
8 years, 4 months ago by benm (inactive)

Modified:
8 years, 4 months ago

Reviewers:
brettw

CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Move base/android/path_service.cc|h to path_service_android.cc|h Gyp targets shouldn't contain source with identical basenames. Fallout from http://src.chromium.org/viewvc/chrome?view=rev&revision=149842 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150110

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -51 lines)			Patch
M	base/android/base_jni_registrar.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
D	base/android/path_service.h	View	1 chunk	+0 lines, -18 lines	0 comments	Download
D	base/android/path_service.cc	View	1 chunk	+0 lines, -26 lines	0 comments	Download
A +	base/android/path_service_android.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	base/android/path_service_android.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/base.gypi	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/10828152/1

8 years, 4 months ago (2012-08-06 08:06:11 UTC) #3

commit-bot: I haz the power

Try job failure for 10828152-1 (retry) on win_rel for step "compile" (clobber build). It's a ...

8 years, 4 months ago (2012-08-06 08:27:21 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/10828152/1

8 years, 4 months ago (2012-08-06 15:03:26 UTC) #5

Change committed as 150110