Issue 10827125: Use JavaObjectWeakGlobalRef in ContentViewCore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10827125: Use JavaObjectWeakGlobalRef in ContentViewCore. (Closed)

Created:
8 years, 4 months ago by nilesh

Modified:
8 years, 4 months ago

Reviewers:
joth, Jesse Greenwald

CC:
chromium-reviews, joi+watch-content_chromium.org, erikwright (departed), darin-cc_chromium.org, jam, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use JavaObjectWeakGlobalRef in ContentViewCore. Java ContentViewCore object may be garbage collected without first destroying the native object. Because of this, all C++->Java calls to ContentViewCore must be guarded with a null check. BUG=139386, 138237 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149570

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+83 lines, -50 lines)			Patch
M	base/android/jni_helper.h	View	3 chunks	+6 lines, -1 line	0 comments	Download
M	base/android/jni_helper.cc	View	2 chunks	+15 lines, -6 lines	0 comments	Download
M	content/browser/android/content_view_core_impl.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/browser/android/content_view_core_impl.cc	View	9 chunks	+31 lines, -26 lines	0 comments	Download
M	content/browser/android/download_controller.h	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	content/browser/android/download_controller.cc	View	5 chunks	+22 lines, -15 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10827125/1

8 years, 4 months ago (2012-08-02 01:58:55 UTC) #4

Change committed as 149570

Expand Messages | Collapse Messages