Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: base/android/jni_helper.cc

Issue 10827125: Use JavaObjectWeakGlobalRef in ContentViewCore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/android/jni_helper.h ('k') | content/browser/android/content_view_core_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/jni_helper.cc
diff --git a/base/android/jni_helper.cc b/base/android/jni_helper.cc
index 5e9f4098501f96f590e40aba3f64ea1923085a44..3ff3bfb1dfb27cafd6499735f4c7b66e283510fa 100644
--- a/base/android/jni_helper.cc
+++ b/base/android/jni_helper.cc
@@ -15,8 +15,14 @@ JavaObjectWeakGlobalRef::JavaObjectWeakGlobalRef(JNIEnv* env, jobject obj)
}
JavaObjectWeakGlobalRef::~JavaObjectWeakGlobalRef() {
- DCHECK(obj_);
- AttachCurrentThread()->DeleteWeakGlobalRef(obj_);
+ reset();
+}
+
+void JavaObjectWeakGlobalRef::reset() {
+ if (obj_) {
+ AttachCurrentThread()->DeleteWeakGlobalRef(obj_);
+ obj_ = NULL;
+ }
}
base::android::ScopedJavaLocalRef<jobject>
@@ -25,9 +31,12 @@ base::android::ScopedJavaLocalRef<jobject>
}
base::android::ScopedJavaLocalRef<jobject> GetRealObject(
- JNIEnv* env, jobject obj) {
- jobject real = env->NewLocalRef(obj);
- if (!real)
- DLOG(ERROR) << "The real object has been deleted!";
+ JNIEnv* env, jweak obj) {
+ jobject real = NULL;
+ if (obj) {
+ real = env->NewLocalRef(obj);
+ if (!real)
+ DLOG(ERROR) << "The real object has been deleted!";
+ }
return base::android::ScopedJavaLocalRef<jobject>(env, real);
}
« no previous file with comments | « base/android/jni_helper.h ('k') | content/browser/android/content_view_core_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698