Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: base/android/jni_helper.h

Issue 10827125: Use JavaObjectWeakGlobalRef in ContentViewCore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | base/android/jni_helper.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_ANDROID_JNI_HELPER_H_ 5 #ifndef BASE_ANDROID_JNI_HELPER_H_
6 #define BASE_ANDROID_JNI_HELPER_H_ 6 #define BASE_ANDROID_JNI_HELPER_H_
7 7
8 #include <jni.h> 8 #include <jni.h>
9 9
10 #include "base/android/scoped_java_ref.h" 10 #include "base/android/scoped_java_ref.h"
11 11
12 // Manages WeakGlobalRef lifecycle. 12 // Manages WeakGlobalRef lifecycle.
13 // This class is not thread-safe w.r.t. get() and reset(). Multiple threads may
14 // safely use get() concurrently, but if the user calls reset() (or of course,
15 // calls the destructor) they'll need to provide their own synchronization.
13 class JavaObjectWeakGlobalRef { 16 class JavaObjectWeakGlobalRef {
14 public: 17 public:
15 JavaObjectWeakGlobalRef(JNIEnv* env, jobject obj); 18 JavaObjectWeakGlobalRef(JNIEnv* env, jobject obj);
16 virtual ~JavaObjectWeakGlobalRef(); 19 virtual ~JavaObjectWeakGlobalRef();
17 20
18 base::android::ScopedJavaLocalRef<jobject> get(JNIEnv* env) const; 21 base::android::ScopedJavaLocalRef<jobject> get(JNIEnv* env) const;
19 22
23 void reset();
24
20 private: 25 private:
21 jweak obj_; 26 jweak obj_;
22 27
23 DISALLOW_COPY_AND_ASSIGN(JavaObjectWeakGlobalRef); 28 DISALLOW_COPY_AND_ASSIGN(JavaObjectWeakGlobalRef);
24 }; 29 };
25 30
26 // Get the real object stored in the weak reference returned as a 31 // Get the real object stored in the weak reference returned as a
27 // ScopedJavaLocalRef. 32 // ScopedJavaLocalRef.
28 base::android::ScopedJavaLocalRef<jobject> GetRealObject( 33 base::android::ScopedJavaLocalRef<jobject> GetRealObject(
29 JNIEnv* env, jobject obj); 34 JNIEnv* env, jweak obj);
30 35
31 #endif // BASE_ANDROID_JNI_HELPER_H_ 36 #endif // BASE_ANDROID_JNI_HELPER_H_
OLDNEW
« no previous file with comments | « no previous file | base/android/jni_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698