Issue 10827037: Extending map verification to also verify LastAdded/DescriptorArray consistency.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10827037: Extending map verification to also verify LastAdded/DescriptorArray consistency. (Closed)

Created:
8 years, 4 months ago by Toon Verwaest

Modified:
8 years, 4 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Extending map verification to also verify LastAdded/DescriptorArray consistency. Removed ASSERT now subsumed by extended map verification. Committed: https://code.google.com/p/v8/source/detail?r=12204

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed comments. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
M	src/heap.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/objects.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects-debug.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

danno

8 years, 4 months ago (2012-07-26 14:42:09 UTC) #2

LGTM with nits

http://codereview.chromium.org/10827037/diff/1/src/objects-debug.cc
File src/objects-debug.cc (right):

http://codereview.chromium.org/10827037/diff/1/src/objects-debug.cc#newcode309
src/objects-debug.cc:309: NumberOfSetDescriptors());
How about NumberOfOwnDescriptors, or just use number_of_descriptors().

Expand Messages | Collapse Messages