src/heap.cc - Issue 10827037: Extending map verification to also verify LastAdded/DescriptorArray consistency.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap.cc

Issue 10827037: Extending map verification to also verify LastAdded/DescriptorArray consistency. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed comments. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap.cc

diff --git a/src/heap.cc b/src/heap.cc

index 69529ad6de97de7d6d3912603b44c372280a8c59..8e64f9e39cc5d02ee46e4b4ed77423c360594754 100644

--- a/src/heap.cc

+++ b/src/heap.cc

@@ -4159,8 +4159,6 @@ MaybeObject* Heap::AllocateGlobalObject(JSFunction* constructor) {

MaybeObject* maybe_map = map->CopyDropDescriptors();

if (!maybe_map->To(&new_map)) return maybe_map;

- ASSERT(new_map->LastAdded() == Map::kNoneAdded);

// Set up the global object as a normalized object.

global->set_map(new_map);

global->set_properties(dictionary);

« no previous file with comments | « no previous file | src/objects.cc » ('j') | no next file with comments »