src/objects.cc - Issue 10827037: Extending map verification to also verify LastAdded/DescriptorArray consistency.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 10827037: Extending map verification to also verify LastAdded/DescriptorArray consistency. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed comments. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 57f416514333a65d65752c4ea1a8698fd8da3301..5b442ed06cfc386c44173778eaa80b4b5a326a9a 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -4872,7 +4872,7 @@ MaybeObject* Map::CopyReplaceDescriptors(DescriptorArray* descriptors,

if (!maybe_result->To(&result)) return maybe_result;

if (last_added == kNoneAdded) {

- ASSERT(descriptors->IsEmpty());

+ ASSERT(descriptors->number_of_descriptors() == 0);

} else {

ASSERT(descriptors->GetDetails(last_added).index() ==

descriptors->number_of_descriptors());

« no previous file with comments | « src/heap.cc ('k') | src/objects-debug.cc » ('j') | no next file with comments »