Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 10826249: Issue 3084. Generate warning, not error, for 'Unknown.unknown' (Closed)

Created:
8 years, 4 months ago by scheglov
Modified:
8 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -6 lines) Patch
M compiler/java/com/google/dart/compiler/resolver/Resolver.java View 3 chunks +4 lines, -3 lines 0 comments Download
M compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java View 1 chunk +4 lines, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java View 1 chunk +1 line, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java View 1 chunk +60 lines, -0 lines 0 comments Download
M tests/co19/co19-compiler.status View 3 chunks +8 lines, -1 line 0 comments Download
M tests/language/language.status View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scheglov
8 years, 4 months ago (2012-08-10 18:10:09 UTC) #1
Brian Wilkerson
8 years, 4 months ago (2012-08-10 18:19:51 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698