Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1001)

Unified Diff: compiler/java/com/google/dart/compiler/resolver/Resolver.java

Issue 10826249: Issue 3084. Generate warning, not error, for 'Unknown.unknown' (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compiler/java/com/google/dart/compiler/resolver/Resolver.java
diff --git a/compiler/java/com/google/dart/compiler/resolver/Resolver.java b/compiler/java/com/google/dart/compiler/resolver/Resolver.java
index 15737738f0eb29a31b48af8307a77e1f9a3e2cca..2ee7d8fe558bc95bdd0d5378e9fed653333c512d 100644
--- a/compiler/java/com/google/dart/compiler/resolver/Resolver.java
+++ b/compiler/java/com/google/dart/compiler/resolver/Resolver.java
@@ -1066,8 +1066,9 @@ public class Resolver {
name, referencedElementName);
}
}
- if (isStaticContextOrInitializer()) {
+ if (isStaticContextOrInitializer() && !isQualifier) {
onError(x, ResolverErrorCode.CANNOT_BE_RESOLVED, name);
+ x.markResolutionAlreadyReportedThatTheMethodCouldNotBeFound();
}
} else {
element = checkResolvedIdentifier(x, isQualifier, scope, name, element);
@@ -1211,7 +1212,7 @@ public class Resolver {
break;
case NONE:
- onError(x.getName(), ResolverErrorCode.CANNOT_BE_RESOLVED,
+ onError(x.getName(), TypeErrorCode.CANNOT_BE_RESOLVED,
x.getPropertyName());
break;
@@ -1256,7 +1257,7 @@ public class Resolver {
break;
case NONE:
- onError(x.getName(), ResolverErrorCode.CANNOT_BE_RESOLVED,
+ onError(x.getName(), TypeErrorCode.CANNOT_BE_RESOLVED,
x.getPropertyName());
break;
« no previous file with comments | « no previous file | compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698