compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java - Issue 10826249: Issue 3084. Generate warning, not error, for 'Unknown.unknown'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

Issue 10826249: Issue 3084. Generate warning, not error, for 'Unknown.unknown' (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/resolver/Resolver.java ('k') | compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

diff --git a/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java b/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

index 339dbb4ca02c8e5d8fe2d4a81a03a6a05f060c47..cd6e35fa65db90f5420471ce832a28331bc65f1b 100644

--- a/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

+++ b/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

@@ -1624,7 +1624,10 @@ public class TypeAnalyzer implements DartCompilationPhase {

break;

case NONE:

- return typeError(node, TypeErrorCode.CANNOT_BE_RESOLVED, node.getName());

+ if (!node.isResolutionAlreadyReportedThatTheMethodCouldNotBeFound()) {

+ typeError(node, TypeErrorCode.CANNOT_BE_RESOLVED, node.getName());

+ }

+ return dynamicType;

case DYNAMIC:

return element.getType();