Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 10826173: Extensions Docs Server: Proper path handling (Closed)

Created:
8 years, 4 months ago by cduvall
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, clintstaley
Visibility:
Public.

Description

Extensions Docs Server: Proper path handling The docs now use paths with the branch first, like 'trunk/apps/storage.html' instead of paths like 'apps/trunk/storage.html'. Also a couple other fixes to the samples page. BUG=131095 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150168

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -23 lines) Patch
M chrome/common/extensions/docs/server2/branch_utility.py View 1 chunk +2 lines, -9 lines 0 comments Download
M chrome/common/extensions/docs/server2/handler.py View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/server2/samples_data_source.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/server_instance.py View 1 chunk +6 lines, -4 lines 2 comments Download
M chrome/common/extensions/docs/server2/static/js/branch.js View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/templates/private/footer.html View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/extensions/samples.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
cduvall
The fix to my previous CL, plus a couple others I found.
8 years, 4 months ago (2012-08-06 23:03:15 UTC) #1
not at google - send to devlin
lgtm https://chromiumcodereview.appspot.com/10826173/diff/6/chrome/common/extensions/docs/server2/server_instance.py File chrome/common/extensions/docs/server2/server_instance.py (right): https://chromiumcodereview.appspot.com/10826173/diff/6/chrome/common/extensions/docs/server2/server_instance.py#newcode45 chrome/common/extensions/docs/server2/server_instance.py:45: DOCS_PATH + '/' + path[len('extensions/'):]) I presume the ...
8 years, 4 months ago (2012-08-06 23:13:46 UTC) #2
cduvall
8 years, 4 months ago (2012-08-06 23:14:55 UTC) #3
https://chromiumcodereview.appspot.com/10826173/diff/6/chrome/common/extensio...
File chrome/common/extensions/docs/server2/server_instance.py (right):

https://chromiumcodereview.appspot.com/10826173/diff/6/chrome/common/extensio...
chrome/common/extensions/docs/server2/server_instance.py:45: DOCS_PATH + '/' +
path[len('extensions/'):])
On 2012/08/06 23:13:46, kalman wrote:
> I presume the apps samples page will be set up to serve .zip files differently
> then?
> 
> I mean, yeah, ideally we should just let github deal with it. I'll need to
look
> at the apps samples review again (will definitely get around to doing that
> today..).

Right now they're just linked to the github page.

Powered by Google App Engine
This is Rietveld 408576698