Extensions Docs Server: Proper path handling

chrome/common/extensions/docs/server2/server_instance.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from fnmatch import fnmatch
 import mimetypes
 import os
 
 STATIC_DIR_PREFIX = 'docs/server2'
 DOCS_PATH = 'docs'
@@ skipping 18 matching lines @@
       result = self._cache.GetFromFile(STATIC_DIR_PREFIX + '/' + path)
       base, ext = os.path.splitext(path)
       response.headers['content-type'] = mimetypes.types_map[ext]
       return result
     except Exception:
       return ''
 
   def Get(self, path, request, response):
     templates = self._template_data_source_factory.Create(request)
 
-    if fnmatch(path, 'examples/*.zip'):
-      content = self._example_zipper.Create(path[:-len('.zip')])
+    if fnmatch(path, 'extensions/examples/*.zip'):
+      content = self._example_zipper.Create(
+          path[len('extensions/'):-len('.zip')])
       response.headers['content-type'] = mimetypes.types_map['.zip']
-    elif path.startswith('examples/'):
-      content = self._cache.GetFromFile(DOCS_PATH + '/' + path)
+    elif path.startswith('extensions/examples/'):
+      content = self._cache.GetFromFile(
+          DOCS_PATH + '/' + path[len('extensions/'):])

[not at google - send to devlin, 2012/08/06 23:13:46]

I presume the apps samples page will be set up to serve .zip files differently
then?

I mean, yeah, ideally we should just let github deal with it. I'll need to look
at the apps samples review again (will definitely get around to doing that
today..).

[cduvall, 2012/08/06 23:14:55]

Right now they're just linked to the github page.

       response.headers['content-type'] = 'text/plain'
     elif path.startswith('static/'):
       content = self._FetchStaticResource(path, response)
     else:
       content = templates.Render(path)
 
     if content:
       response.out.write(content)
     else:
       response.set_status(404);
       response.out.write(templates.Render('404'))