Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 10825188: Add comment explaining fix and added explicit HistoryService dependency in predictor. (Closed)

Created:
8 years, 4 months ago by dominich
Modified:
8 years, 4 months ago
Reviewers:
Shishir, Scott Byer
CC:
chromium-reviews
Visibility:
Public.

Description

Add comment explaining fix and added explicit HistoryService dependency in predictor. R=scottbyer@chromium.org,shishir@chromium.org BUG=140466 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150120

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/browser/predictors/predictor_database.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/cloud_print/test/cloud_print_policy_browsertest.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
dominich
8 years, 4 months ago (2012-08-03 21:01:37 UTC) #1
Shishir
lgtm
8 years, 4 months ago (2012-08-03 21:03:02 UTC) #2
Scott Byer
lgtm
8 years, 4 months ago (2012-08-03 21:04:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominich@chromium.org/10825188/1
8 years, 4 months ago (2012-08-03 21:12:15 UTC) #4
commit-bot: I haz the power
Try job failure for 10825188-1 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-03 21:37:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominich@chromium.org/10825188/1
8 years, 4 months ago (2012-08-03 21:39:06 UTC) #6
commit-bot: I haz the power
Try job failure for 10825188-1 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-03 21:57:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominich@chromium.org/10825188/1
8 years, 4 months ago (2012-08-03 22:02:05 UTC) #8
commit-bot: I haz the power
Try job failure for 10825188-1 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-03 22:23:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominich@chromium.org/10825188/1
8 years, 4 months ago (2012-08-06 16:05:51 UTC) #10
commit-bot: I haz the power
8 years, 4 months ago (2012-08-06 18:45:06 UTC) #11
Change committed as 150120

Powered by Google App Engine
This is Rietveld 408576698