Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Side by Side Diff: chrome/browser/predictors/resource_prefetch_predictor_factory.cc

Issue 10825188: Add comment explaining fix and added explicit HistoryService dependency in predictor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/predictors/resource_prefetch_predictor_factory.h" 5 #include "chrome/browser/predictors/resource_prefetch_predictor_factory.h"
6 6
7 #include "chrome/browser/history/history_service_factory.h"
7 #include "chrome/browser/predictors/predictor_database_factory.h" 8 #include "chrome/browser/predictors/predictor_database_factory.h"
8 #include "chrome/browser/predictors/resource_prefetch_predictor.h" 9 #include "chrome/browser/predictors/resource_prefetch_predictor.h"
9 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
10 #include "chrome/browser/profiles/profile_dependency_manager.h" 11 #include "chrome/browser/profiles/profile_dependency_manager.h"
11 12
12 namespace predictors { 13 namespace predictors {
13 14
14 // static 15 // static
15 ResourcePrefetchPredictor* ResourcePrefetchPredictorFactory::GetForProfile( 16 ResourcePrefetchPredictor* ResourcePrefetchPredictorFactory::GetForProfile(
16 Profile* profile) { 17 Profile* profile) {
17 return static_cast<ResourcePrefetchPredictor*>( 18 return static_cast<ResourcePrefetchPredictor*>(
18 GetInstance()->GetServiceForProfile(profile, true)); 19 GetInstance()->GetServiceForProfile(profile, true));
19 } 20 }
20 21
21 // static 22 // static
22 ResourcePrefetchPredictorFactory* 23 ResourcePrefetchPredictorFactory*
23 ResourcePrefetchPredictorFactory::GetInstance() { 24 ResourcePrefetchPredictorFactory::GetInstance() {
24 return Singleton<ResourcePrefetchPredictorFactory>::get(); 25 return Singleton<ResourcePrefetchPredictorFactory>::get();
25 } 26 }
26 27
27 ResourcePrefetchPredictorFactory::ResourcePrefetchPredictorFactory() 28 ResourcePrefetchPredictorFactory::ResourcePrefetchPredictorFactory()
28 : ProfileKeyedServiceFactory("ResourcePrefetchPredictor", 29 : ProfileKeyedServiceFactory("ResourcePrefetchPredictor",
29 ProfileDependencyManager::GetInstance()) { 30 ProfileDependencyManager::GetInstance()) {
30 // TODO(shishir): Uncomment this when crbug.com/97804 is fixed. 31 DependsOn(HistoryServiceFactory::GetInstance());
31 // DependsOn(HistoryServiceFactory::GetInstance());
32 DependsOn(PredictorDatabaseFactory::GetInstance()); 32 DependsOn(PredictorDatabaseFactory::GetInstance());
33 } 33 }
34 34
35 ResourcePrefetchPredictorFactory::~ResourcePrefetchPredictorFactory() {} 35 ResourcePrefetchPredictorFactory::~ResourcePrefetchPredictorFactory() {}
36 36
37 ProfileKeyedService* 37 ProfileKeyedService*
38 ResourcePrefetchPredictorFactory::BuildServiceInstanceFor( 38 ResourcePrefetchPredictorFactory::BuildServiceInstanceFor(
39 Profile* profile) const { 39 Profile* profile) const {
40 return ResourcePrefetchPredictor::IsEnabled(profile) ? 40 return ResourcePrefetchPredictor::IsEnabled(profile) ?
41 new ResourcePrefetchPredictor(ResourcePrefetchPredictor::Config(), 41 new ResourcePrefetchPredictor(ResourcePrefetchPredictor::Config(),
42 profile) : 42 profile) :
43 NULL; 43 NULL;
44 } 44 }
45 45
46 } // namespace predictors 46 } // namespace predictors
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698