chrome/browser/predictors/resource_prefetch_predictor_factory.cc - Issue 10825188: Add comment explaining fix and added explicit HistoryService dependency in predictor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/predictors/resource_prefetch_predictor_factory.cc

Issue 10825188: Add comment explaining fix and added explicit HistoryService dependency in predictor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/predictors/predictor_database.cc ('k') | chrome/browser/printing/cloud_print/test/cloud_print_policy_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/predictors/resource_prefetch_predictor_factory.cc

diff --git a/chrome/browser/predictors/resource_prefetch_predictor_factory.cc b/chrome/browser/predictors/resource_prefetch_predictor_factory.cc

index ee4dce7e5bb9ca6830e414e86f1f1be27886b113..b58c8ed8c7f61f76a0cd88e890413dccb2483246 100644

--- a/chrome/browser/predictors/resource_prefetch_predictor_factory.cc

+++ b/chrome/browser/predictors/resource_prefetch_predictor_factory.cc

@@ -4,6 +4,7 @@

#include "chrome/browser/predictors/resource_prefetch_predictor_factory.h"

+#include "chrome/browser/history/history_service_factory.h"

#include "chrome/browser/predictors/predictor_database_factory.h"

#include "chrome/browser/predictors/resource_prefetch_predictor.h"

#include "chrome/browser/profiles/profile.h"

@@ -27,8 +28,7 @@ ResourcePrefetchPredictorFactory::GetInstance() {

ResourcePrefetchPredictorFactory::ResourcePrefetchPredictorFactory()

: ProfileKeyedServiceFactory("ResourcePrefetchPredictor",

ProfileDependencyManager::GetInstance()) {

- // TODO(shishir): Uncomment this when crbug.com/97804 is fixed.

- // DependsOn(HistoryServiceFactory::GetInstance());

+ DependsOn(HistoryServiceFactory::GetInstance());

DependsOn(PredictorDatabaseFactory::GetInstance());

}